Uploaded image for project: 'Giraph (Retired)'
  1. Giraph (Retired)
  2. GIRAPH-537

Fix log messages produced by aggregators

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      When workers are synchronizing aggregators using the ExpectedBarrier class, the following message is printed:

      "waitForRequiredPermits: Waiting for times required to be X (currently Y)"

      I find this doesn't convey much about what exactly we're waiting for.

      We should make the log more meaningful and explicitly mention aggregators, at the cost of simplifying things a bit.
      Additionally, we could skip it altogether when no aggregators are being used.

      The ExpectedBarrier class itself also lacks clear documentation: what is this class for? The Javadoc explains how it works without first stating what it is.

      Attachments

        1. GIRAPH-537.patch
          31 kB
          Maja Kabiljo
        2. GIRAPH-537.patch
          29 kB
          Maja Kabiljo

        Issue Links

          Activity

            People

              majakabiljo Maja Kabiljo
              apresta Alessandro Presta
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: