Giraph
  1. Giraph
  2. GIRAPH-445

Max message request size in bytes, initialize buffers to expected size

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Now that all message requests are kept in serialized format, we can limit the size of request by the number of bytes, instead of number of messages in it. Sizing the message buffers to expected size gave about 10% speedup on a large application run.

      1. GIRAPH-445.patch
        12 kB
        Maja Kabiljo
      2. GIRAPH-445-1.patch
        12 kB
        Maja Kabiljo

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1m 48s 1 Maja Kabiljo 07/Dec/12 17:07
        Patch Available Patch Available Resolved Resolved
        3d 1h 56m 1 Maja Kabiljo 10/Dec/12 19:04
        Maja Kabiljo made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Giraph-trunk-Commit #306 (See https://builds.apache.org/job/Giraph-trunk-Commit/306/)
        GIRAPH-445: Max message request size in bytes, initialize buffers to expected size (Revision 1419623)

        Result = SUCCESS
        maja : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419623
        Files :

        • /giraph/trunk/CHANGELOG
        • /giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java
        • /giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/SendMessageCache.java
        • /giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
        Show
        Hudson added a comment - Integrated in Giraph-trunk-Commit #306 (See https://builds.apache.org/job/Giraph-trunk-Commit/306/ ) GIRAPH-445 : Max message request size in bytes, initialize buffers to expected size (Revision 1419623) Result = SUCCESS maja : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419623 Files : /giraph/trunk/CHANGELOG /giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java /giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/SendMessageCache.java /giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
        Maja Kabiljo made changes -
        Attachment GIRAPH-445-1.patch [ 12560226 ]
        Show
        Maja Kabiljo added a comment - https://reviews.apache.org/r/8407/
        Maja Kabiljo made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Maja Kabiljo added a comment -

        In the future we can also have the additional buffer size parameter set automatically.

        Show
        Maja Kabiljo added a comment - In the future we can also have the additional buffer size parameter set automatically.
        Maja Kabiljo made changes -
        Attachment GIRAPH-445.patch [ 12559896 ]
        Maja Kabiljo made changes -
        Field Original Value New Value
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Maja Kabiljo created issue -

          People

          • Assignee:
            Maja Kabiljo
            Reporter:
            Maja Kabiljo
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development