Uploaded image for project: 'Giraph (Retired)'
  1. Giraph (Retired)
  2. GIRAPH-444

Cleanup VertexResolver

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None

    Description

      Few minor but necessary touchups to VertexResolver:

      1) We're using VertexResolver in a bunch of places when we should be using BasicVertexResolver (the interface). On that note seems to me these two names should be flipped, that is VertexResolver should be the interface and BasicVertexResolver the default implementation. Thoughts?
      2) Add GraphStateConfigurable interface similar to Configurable.
      3) Add a boolean option for user to control whether to create vertex for a vertex that didn't exist but got messages. Need this for an algorithm I'm working on and seems to me to be general enough of a decision that we should allow user to control it.
      4) General cleanup of VertexResolver logic into separate functions (no logic change).

      https://reviews.apache.org/r/8370/

      Attachments

        1. GIRAPH-444.patch
          21 kB
          Nitay Joffe

        Issue Links

          Activity

            People

              nitay Nitay Joffe
              nitay Nitay Joffe
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: