Giraph
  1. Giraph
  2. GIRAPH-440

ProgressableUtils - TimeoutException from future.get shouldn't be rethrown

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Introduced by GIRAPH-437 - when Future.get() throws TimeoutException we should catch it and continue waiting.

        Activity

        Hide
        Maja Kabiljo added a comment -

        Thanks Avery

        Show
        Maja Kabiljo added a comment - Thanks Avery
        Hide
        Hudson added a comment -

        Integrated in Giraph-trunk-Commit #302 (See https://builds.apache.org/job/Giraph-trunk-Commit/302/)
        GIRAPH-440: ProgressableUtils - TimeoutException from future.get shouldn't be rethrown (Revision 1415867)

        Result = SUCCESS
        maja : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415867
        Files :

        • /giraph/trunk/CHANGELOG
        • /giraph/trunk/giraph/src/main/java/org/apache/giraph/utils/ProgressableUtils.java
        Show
        Hudson added a comment - Integrated in Giraph-trunk-Commit #302 (See https://builds.apache.org/job/Giraph-trunk-Commit/302/ ) GIRAPH-440 : ProgressableUtils - TimeoutException from future.get shouldn't be rethrown (Revision 1415867) Result = SUCCESS maja : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415867 Files : /giraph/trunk/CHANGELOG /giraph/trunk/giraph/src/main/java/org/apache/giraph/utils/ProgressableUtils.java
        Hide
        Avery Ching added a comment -

        +1, just might want to wrap

        LOG.info("waitFor: Future result not ready yet " + future);

        in a LOG.isInfoEnabled() block

        Show
        Avery Ching added a comment - +1, just might want to wrap LOG.info("waitFor: Future result not ready yet " + future); in a LOG.isInfoEnabled() block

          People

          • Assignee:
            Maja Kabiljo
            Reporter:
            Maja Kabiljo
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development