Yep, here's what I did to test this patch:
1) Edit pom.xml replace $
with path to my Facebook Hadoop jar. Is there a way to do this as some environment variable or something? I can also try updating the loop script to pass this in as a command line option, but that seems kinda hacky - I like that script as it is since it is completely generic (actually using it for other projects as well).
2) dev-support/for-each-profile.sh -DskipTests clean install
Ideally we can get rid of (1) by having FB hadoop jar published somewhere public.
We can also make (2) the recommended "really thorough" way to test patches or something? Obviously other patches should remove -DskipTests, but right now I see some failures even in trunk and this diff didn't touch any tests so I'm assuming they're not related.