[GIRAPH-269] TestGraphPartitioner is broken and probably not robust

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Assignee: Unassigned
• Reporter: Alessandro Presta
• Created: 25/Jul/12 15:58
• Updated: 12/May/20 18:27
• Resolved: 12/May/20 18:27

Description

TestGraphPartitioner (distributed-mode only) currently fails with:

testPartitioners(org.apache.giraph.TestGraphPartitioner)  Time elapsed: 65.195 sec  <<< FAILURE!
java.lang.AssertionError: expected:<123> but was:<120>
	at org.junit.Assert.fail(Assert.java:58)
	at org.junit.Assert.failNotEquals(Assert.java:259)
	at org.junit.Assert.assertEquals(Assert.java:80)
	at org.junit.Assert.assertEquals(Assert.java:88)
	at org.apache.giraph.TestGraphPartitioner.verifyOutput(TestGraphPartitioner.java:59)
	at org.apache.giraph.TestGraphPartitioner.testPartitioners(TestGraphPartitioner.java:96)

This is most likely due to the serialization changes that came with GIRAPH-244.

The test isn't commented so I can't figure out how we came up with 123 as the correct number of bytes, but if that depends on the serialization format, then it's not a robust test.

We should replace the check with something that doesn't depend on bytes count, or, if impossible, remove the test case.

Issue Links

• relates to: GIRAPH-276 Fix broken tests in pseudo-distributed mode