Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-269

TestGraphPartitioner is broken and probably not robust

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      TestGraphPartitioner (distributed-mode only) currently fails with:

      testPartitioners(org.apache.giraph.TestGraphPartitioner)  Time elapsed: 65.195 sec  <<< FAILURE!
      java.lang.AssertionError: expected:<123> but was:<120>
      	at org.junit.Assert.fail(Assert.java:58)
      	at org.junit.Assert.failNotEquals(Assert.java:259)
      	at org.junit.Assert.assertEquals(Assert.java:80)
      	at org.junit.Assert.assertEquals(Assert.java:88)
      	at org.apache.giraph.TestGraphPartitioner.verifyOutput(TestGraphPartitioner.java:59)
      	at org.apache.giraph.TestGraphPartitioner.testPartitioners(TestGraphPartitioner.java:96)
      

      This is most likely due to the serialization changes that came with GIRAPH-244.

      The test isn't commented so I can't figure out how we came up with 123 as the correct number of bytes, but if that depends on the serialization format, then it's not a robust test.

      We should replace the check with something that doesn't depend on bytes count, or, if impossible, remove the test case.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                apresta Alessandro Presta
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: