[GIRAPH-221] Make iteration over edges more explicit

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: graph
• Assignee: Alessandro Presta
• Reporter: Alessandro Presta
• Created: 27/Jun/12 16:49
• Updated: 10/Jul/12 16:56
• Resolved: 02/Jul/12 08:30

Description

Is there any particular reason why BasicVertex implements Iterable?

It seems to me that doing

for (I neighbor : vertex)

is not that explicit, and

for (I neighbor : this)

gets even obscure (which may be why all examples in the codebase explicitly instantiate an iterator and call next()).

What I propose is a more explicit

Iterator<I> outEdgesIterator()

and also a convenient

Iterable<I> outEdges()

so, for example, an algorithm can use

for (IntWritable neighbor : outEdges())

Issue Links

• relates to: GIRAPH-244 Vertex API redesign