Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-216

NullWritable as VertexData, EdgeData or MessageData should be allowed

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: None
    • Labels:
      None

      Description

      When using NullWritable as VertexData, EdgeData or MessageData, an error occurs. This happens because the constructor of NullWritable is private, so ReflectionUtils.newInstance() fails. The solution is checking for NullWritable separately, and then returning NullWritable.get() instead of a new class. This can save very large amounts of memory, since NullWritable is a singleton.

      This was reported on the mailing list, but never fixed: http://mail-archives.apache.org/mod_mbox/incubator-giraph-user/201112.mbox/%3C4EDED788.4020904@apache.org%3E

        Attachments

        1. GIRAPH-216.patch
          4 kB
          Jan van der Lugt
        2. GIRAPH-216.patch
          6 kB
          Jan van der Lugt
        3. GIRAPH-216-3.patch
          6 kB
          Jakob Homan
        4. GIRAPH-216.patch
          6 kB
          Jan van der Lugt

          Activity

            People

            • Assignee:
              janlugt Jan van der Lugt
              Reporter:
              janlugt Jan van der Lugt
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified