Uploaded image for project: 'Giraph (Retired)'
  1. Giraph (Retired)
  2. GIRAPH-205

Move Giraph jar to root level of tar.gz

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.0.0
    • 1.0.0
    • conf and scripts
    • None

    Description

      I see the following bit of code in bin/giraph:

              for f in $GIRAPH_HOME/lib/giraph*.jar ; do
                if [ -e "$f" ]; then
                  JAR=$f
                  break
                fi
              done
      

      I find it puzzling that it doesn't look for $GIRAPH_HOME/giraph*.jar

      In fact, I find it puzzling that it looks under lib at all, since my assumption is that lib is supposed to hold the dependencies only.

      Either way, I suggest that we modify it to be:

              for f in $GIRAPH_HOME/lib/giraph*.jar $GIRAPH_HOME/giraph*.jar  ; do
                if [ -e "$f" ]; then
                  JAR=$f
                  break
                fi
              done
      

      Thoughts?

      Attachments

        1. GIRAPH-205-fix.patch
          0.4 kB
          Eli Reisman
        2. GIRAPH-205.patch.txt
          1 kB
          Roman Shaposhnik

        Activity

          People

            rvs Roman Shaposhnik
            rvs Roman Shaposhnik
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: