Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-205

Move Giraph jar to root level of tar.gz

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.0.0
    • Component/s: conf and scripts
    • Labels:
      None

      Description

      I see the following bit of code in bin/giraph:

              for f in $GIRAPH_HOME/lib/giraph*.jar ; do
                if [ -e "$f" ]; then
                  JAR=$f
                  break
                fi
              done
      

      I find it puzzling that it doesn't look for $GIRAPH_HOME/giraph*.jar

      In fact, I find it puzzling that it looks under lib at all, since my assumption is that lib is supposed to hold the dependencies only.

      Either way, I suggest that we modify it to be:

              for f in $GIRAPH_HOME/lib/giraph*.jar $GIRAPH_HOME/giraph*.jar  ; do
                if [ -e "$f" ]; then
                  JAR=$f
                  break
                fi
              done
      

      Thoughts?

        Attachments

        1. GIRAPH-205.patch.txt
          1 kB
          Roman Shaposhnik
        2. GIRAPH-205-fix.patch
          0.4 kB
          Eli Reisman

          Activity

            People

            • Assignee:
              rvs Roman Shaposhnik
              Reporter:
              rvs Roman Shaposhnik
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: