Giraph
  1. Giraph
  2. GIRAPH-187

SequenceFileVertexInputFormat has WritableComparable<I> as a bounded type for I

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: None
    • Component/s: lib
    • Labels:
      None

      Description

      This is the first JIRA I ever file, so please let me know if I'm not doing this right.
      Basically, SequenceFileVertexInputFormat has WritableComparable<I> as a bounded type for I, while the Hadoop serializable data types implement WritableComparable. Because of this, I suspect TextVertexInputFormat only has WritableComparable as a bounded type for I and has a SuppressWarnings("rawtypes") annotation. I think SequenceFileVertexInputFormat should follow the same style, otherwise it's not possible to use, for example, IntComparable as vertex id type in a SequenceVertexInputFormat.

        Activity

        Hide
        Roman K added a comment -

        Type changed so that SequenceFileVertexInputFormat can be used with types such as the Hadoop's IntWritable.

        "mvn compile" and simple test class compiled properly.

        Show
        Roman K added a comment - Type changed so that SequenceFileVertexInputFormat can be used with types such as the Hadoop's IntWritable. "mvn compile" and simple test class compiled properly.
        Hide
        Avery Ching added a comment -

        +1, committed. Thanks Roman!

        Show
        Avery Ching added a comment - +1, committed. Thanks Roman!
        Hide
        Hudson added a comment -

        Integrated in Giraph-trunk-Commit #111 (See https://builds.apache.org/job/Giraph-trunk-Commit/111/)
        GIRAPH-187: SequenceFileVertexInputFormat has WritableComparable<I> as
        a bounded type for I. (roman4asf via aching ) (Revision 1343974)

        Result = SUCCESS
        aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1343974
        Files :

        • /giraph/trunk/CHANGELOG
        • /giraph/trunk/src/main/java/org/apache/giraph/lib/SequenceFileVertexInputFormat.java
        Show
        Hudson added a comment - Integrated in Giraph-trunk-Commit #111 (See https://builds.apache.org/job/Giraph-trunk-Commit/111/ ) GIRAPH-187 : SequenceFileVertexInputFormat has WritableComparable<I> as a bounded type for I. (roman4asf via aching ) (Revision 1343974) Result = SUCCESS aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1343974 Files : /giraph/trunk/CHANGELOG /giraph/trunk/src/main/java/org/apache/giraph/lib/SequenceFileVertexInputFormat.java

          People

          • Assignee:
            Roman K
            Reporter:
            Jan van der Lugt
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development