Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Presently Giraph uses JUnit 3.8.1. We can upgrade to JUnit 4

      1. GIRAPH-184.patch
        77 kB
        Devaraj K
      2. GIRAPH-184-1.patch
        78 kB
        Devaraj K
      3. GIRAPH-184-2.patch
        46 kB
        Devaraj K

        Activity

        Hide
        Avery Ching added a comment -

        Sounds good. Would you like to work on this Devaraj?

        Show
        Avery Ching added a comment - Sounds good. Would you like to work on this Devaraj?
        Hide
        Devaraj K added a comment -

        Sure Avery, I will start working on this.

        Show
        Devaraj K added a comment - Sure Avery, I will start working on this.
        Hide
        Avery Ching added a comment -

        Thanks!

        Show
        Avery Ching added a comment - Thanks!
        Hide
        Devaraj K added a comment -

        I have attached patch to address this. Please review the patch.

        Show
        Devaraj K added a comment - I have attached patch to address this. Please review the patch.
        Hide
        Eugene Koontz added a comment -

        Hi Devaraj,
        I noticed in your patch, for src/test/java/org/apache/giraph/TestBspBasic.java, you added:

        import org.junit.Assert;
        import org.junit.Test;
        

        within the scope of a munge ifdef - it should be outside of the ifdef, shouldn't it?

        Even with this fix, I get 7 test failures:

        Results :
        
        Tests in error: 
          initializationError0(org.apache.giraph.TestManualCheckpoint)
          initializationError0(org.apache.giraph.TestAutoCheckpoint)
          initializationError0(org.apache.giraph.TestBspBasic)
          initializationError0(org.apache.giraph.TestGraphPartitioner)
          initializationError0(org.apache.giraph.TestNotEnoughMapTasks)
          initializationError0(org.apache.giraph.TestMutateGraphVertex)
          initializationError0(org.apache.giraph.TestJsonBase64Format)
        
        Tests run: 50, Failures: 0, Errors: 7, Skipped: 0
        
        
        Show
        Eugene Koontz added a comment - Hi Devaraj, I noticed in your patch, for src/test/java/org/apache/giraph/TestBspBasic.java , you added: import org.junit.Assert; import org.junit.Test; within the scope of a munge ifdef - it should be outside of the ifdef, shouldn't it? Even with this fix, I get 7 test failures: Results : Tests in error: initializationError0(org.apache.giraph.TestManualCheckpoint) initializationError0(org.apache.giraph.TestAutoCheckpoint) initializationError0(org.apache.giraph.TestBspBasic) initializationError0(org.apache.giraph.TestGraphPartitioner) initializationError0(org.apache.giraph.TestNotEnoughMapTasks) initializationError0(org.apache.giraph.TestMutateGraphVertex) initializationError0(org.apache.giraph.TestJsonBase64Format) Tests run: 50, Failures: 0, Errors: 7, Skipped: 0
        Hide
        Eugene Koontz added a comment -

        Hi Devaraj,
        I noticed in your patch, for src/test/java/org/apache/giraph/TestBspBasic.java, you added:

        import org.junit.Assert;
        import org.junit.Test;
        

        within the scope of a munge ifdef - it should be outside of the ifdef, shouldn't it?

        Even with this fix, I get 7 test failures:

        Results :
        
        Tests in error: 
          initializationError0(org.apache.giraph.TestManualCheckpoint)
          initializationError0(org.apache.giraph.TestAutoCheckpoint)
          initializationError0(org.apache.giraph.TestBspBasic)
          initializationError0(org.apache.giraph.TestGraphPartitioner)
          initializationError0(org.apache.giraph.TestNotEnoughMapTasks)
          initializationError0(org.apache.giraph.TestMutateGraphVertex)
          initializationError0(org.apache.giraph.TestJsonBase64Format)
        
        Tests run: 50, Failures: 0, Errors: 7, Skipped: 0
        
        
        Show
        Eugene Koontz added a comment - Hi Devaraj, I noticed in your patch, for src/test/java/org/apache/giraph/TestBspBasic.java , you added: import org.junit.Assert; import org.junit.Test; within the scope of a munge ifdef - it should be outside of the ifdef, shouldn't it? Even with this fix, I get 7 test failures: Results : Tests in error: initializationError0(org.apache.giraph.TestManualCheckpoint) initializationError0(org.apache.giraph.TestAutoCheckpoint) initializationError0(org.apache.giraph.TestBspBasic) initializationError0(org.apache.giraph.TestGraphPartitioner) initializationError0(org.apache.giraph.TestNotEnoughMapTasks) initializationError0(org.apache.giraph.TestMutateGraphVertex) initializationError0(org.apache.giraph.TestJsonBase64Format) Tests run: 50, Failures: 0, Errors: 7, Skipped: 0
        Hide
        Eugene Koontz added a comment -

        (sorry for the double post)

        Show
        Eugene Koontz added a comment - (sorry for the double post)
        Hide
        Devaraj K added a comment -

        Thanks a lot Eugene for looking into the patch.

        It is my bad, I couldn't notice these failures due to my env prob. Sorry for the inconvenience.

        I have updated the patch, I verified all the tests pass with the patch.

        Show
        Devaraj K added a comment - Thanks a lot Eugene for looking into the patch. It is my bad, I couldn't notice these failures due to my env prob. Sorry for the inconvenience. I have updated the patch, I verified all the tests pass with the patch.
        Hide
        Jakob Homan added a comment -

        We can dramatically shrink this patch with static imports to make this type of change unnecessary:

        -        assertFalse(ComparisonUtils.equal(one, two));
        -        assertFalse(ComparisonUtils.equal(two, one));
        +        Assert.assertFalse(ComparisonUtils.equal(one, two));
        +        Assert.assertFalse(ComparisonUtils.equal(two, one));
        Show
        Jakob Homan added a comment - We can dramatically shrink this patch with static imports to make this type of change unnecessary: - assertFalse(ComparisonUtils.equal(one, two)); - assertFalse(ComparisonUtils.equal(two, one)); + Assert.assertFalse(ComparisonUtils.equal(one, two)); + Assert.assertFalse(ComparisonUtils.equal(two, one));
        Hide
        Devaraj K added a comment -

        It is good idea Jacob. I will update the patch with this change.

        Show
        Devaraj K added a comment - It is good idea Jacob. I will update the patch with this change.
        Hide
        Devaraj K added a comment -

        I updated the patch, Please review it.

        Show
        Devaraj K added a comment - I updated the patch, Please review it.
        Hide
        Jakob Homan added a comment -

        +1. There are a couple other changes in terms of simplifying boolean == true, but that's fine.

        Show
        Jakob Homan added a comment - +1. There are a couple other changes in terms of simplifying boolean == true , but that's fine.
        Hide
        Jakob Homan added a comment -

        I've committed this. Resolving. Thanks, Devaraj.

        Show
        Jakob Homan added a comment - I've committed this. Resolving. Thanks, Devaraj.
        Hide
        Hudson added a comment -

        Integrated in Giraph-trunk-Commit #105 (See https://builds.apache.org/job/Giraph-trunk-Commit/105/)
        GIRAPH-184. Upgrade to junit4. Contributed by Devaraj K. (Revision 1327637)

        Result = SUCCESS
        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327637
        Files :

        • /incubator/giraph/trunk/CHANGELOG
        • /incubator/giraph/trunk/pom.xml
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/BspCase.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestPredicateLock.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexTypes.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/comm/RPCCommunicationsTest.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/MinimumIntCombinerTest.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/SimpleShortestPathVertexTest.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/TryMultiRpcBindingPortsTest.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestAdjacencyListTextVertexOutputFormat.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestIdWithValueTextOutputFormat.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java
        • /incubator/giraph/trunk/src/test/java/org/apache/giraph/utils/ComparisonUtilsTest.java
        • /incubator/giraph/trunk/src/test/java/zk/TestZooKeeperManager.java
        Show
        Hudson added a comment - Integrated in Giraph-trunk-Commit #105 (See https://builds.apache.org/job/Giraph-trunk-Commit/105/ ) GIRAPH-184 . Upgrade to junit4. Contributed by Devaraj K. (Revision 1327637) Result = SUCCESS jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327637 Files : /incubator/giraph/trunk/CHANGELOG /incubator/giraph/trunk/pom.xml /incubator/giraph/trunk/src/test/java/org/apache/giraph/BspCase.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestPredicateLock.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestVertexTypes.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/comm/RPCCommunicationsTest.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/MinimumIntCombinerTest.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/SimpleShortestPathVertexTest.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/examples/TryMultiRpcBindingPortsTest.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestAdjacencyListTextVertexOutputFormat.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestIdWithValueTextOutputFormat.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/lib/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java /incubator/giraph/trunk/src/test/java/org/apache/giraph/utils/ComparisonUtilsTest.java /incubator/giraph/trunk/src/test/java/zk/TestZooKeeperManager.java

          People

          • Assignee:
            Devaraj K
            Reporter:
            Devaraj K
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development