Uploaded image for project: 'Giraph (Retired)'
  1. Giraph (Retired)
  2. GIRAPH-179

BspServiceMaster's PathFilter can be simplified

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 1.0.0
    • 1.0.0
    • None

    Description

        /**
         * Only get the finalized checkpoint files
         */
        public static class FinalizedCheckpointPathFilter implements PathFilter {
          @Override
          public boolean accept(Path path) {
            if (path.getName().endsWith(
                BspService.CHECKPOINT_FINALIZED_POSTFIX)) {
              return true;
            }
            return false;
          }
        }

      we can simplify this, eliminating the if statement and just returning the result of endsWith()

      Attachments

        1. GIRAPH-179.patch
          0.7 kB
          Devaraj Kavali

        Activity

          People

            devaraj Devaraj Kavali
            jghoman Jakob Homan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: