Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-176

BasicRPCCommunications has unnecessary cast of Vertex

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0
    • Component/s: None
    • Labels:
      None

      Description

      BasicRPCCommunications.java, 1224:

            BasicVertex<I, V, E, M> vertex =
                vertexResolver.resolve(vertexIndex,
                    originalVertex,
                    vertexMutations,
                    messages);

      and then a few lines later at 1248:

              partition.putVertex((BasicVertex<I, V, E, M>) vertex);

      vertex gets cast to its own type. This cast can be removed.

        Attachments

        1. GIRAPH-176.patch
          0.7 kB
          Devaraj K

          Activity

            People

            • Assignee:
              devaraj.k Devaraj K
              Reporter:
              jghoman Jakob Homan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: