Uploaded image for project: 'Giraph (Retired)'
  1. Giraph (Retired)
  2. GIRAPH-175

Replace manual array copy to utility method call

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 1.0.0
    • None
    • None

    Description

            String[] zkJavaOptsArray = zkJavaOptsString.split(" ");
            if (zkJavaOptsArray != null) {
              for (String javaOpt : zkJavaOptsArray) {
                commandList.add(javaOpt);
              }
            }

      Rather than doing the loop ourselves, Collections.addAll would be simpler (and faster, though that doesn't matter with such a small array). Still cleaner, though.

      Attachments

        1. GIRAPH-175.patch
          0.7 kB
          Devaraj Kavali

        Activity

          People

            devaraj Devaraj Kavali
            jghoman Jakob Homan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: