Giraph
  1. Giraph
  2. GIRAPH-131

enable creation of test-jars to simplify testing in downstream projects

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: None
    • Labels:
      None

      Description

      Attached patch enables the creation of test-jars, which are the tests packaged in a separate jar file. This makes it possible to use the super-useful test infrastructure in MockUtils in downstream projects. If you add the patch, you will get a $

      {giraph.version}-tests.jar, which can be used for downstream testing like this:

      <dependency>
      <groupId>org.apache.giraph</groupId>
      <artifactId>giraph</artifactId>
      <version>${giraph.version}

      </version>
      <type>test-jar</type>
      <scope>test</scope>
      </dependency>

      P.S.: The patch also resets the version to 0.1-SNAPSHOT as discussed in GIRAPH-129

      1. GIRAPH-131.patch
        1.0 kB
        André Kelpe
      2. GIRAPH-131-source-test-jar.patch
        0.3 kB
        Eric Charles

        Activity

        Hide
        Jakob Homan added a comment -

        Great. Yes, please open a new JIRA. Usually it's one patch per JIRA, just for attribution and bookkeeping purposes. Thanks.

        Show
        Jakob Homan added a comment - Great. Yes, please open a new JIRA. Usually it's one patch per JIRA, just for attribution and bookkeeping purposes. Thanks.
        Hide
        André Kelpe added a comment -

        Eric, good catch. I totally overlooked that, this should really be added.

        Show
        André Kelpe added a comment - Eric, good catch. I totally overlooked that, this should really be added.
        Hide
        Eric Charles added a comment -

        Hi Jakob,
        Andre's patch works great
        I just wanted to complete it by enabling the presence of giraph-0.1-SNAPSHOT-test-sources.jar.
        Without my patch, you will get the giraph-0.1-SNAPSHOT-tests.jar, and not the giraph-0.1-SNAPSHOT-test-sources.jar
        Maybe I should have opened another JIRA for this, but I tough this was not really needed due to the very small change, and also because it is in a way related to this GIRAPH-131.
        Just tell me if you prefer to manage this in a separate JIRA.
        Thx,
        Eric

        Show
        Eric Charles added a comment - Hi Jakob, Andre's patch works great I just wanted to complete it by enabling the presence of giraph-0.1-SNAPSHOT-test-sources.jar. Without my patch, you will get the giraph-0.1-SNAPSHOT-tests.jar, and not the giraph-0.1-SNAPSHOT-test- sources .jar Maybe I should have opened another JIRA for this, but I tough this was not really needed due to the very small change, and also because it is in a way related to this GIRAPH-131 . Just tell me if you prefer to manage this in a separate JIRA. Thx, Eric
        Hide
        Jakob Homan added a comment -

        Hey Eric- This issue's been resolved with Andre's patch. Does it not work for you?

        Show
        Jakob Homan added a comment - Hey Eric- This issue's been resolved with Andre's patch. Does it not work for you?
        Hide
        Eric Charles added a comment -

        GIRAPH-131-source-test-jar.patch allows the deployment of the test-jar sources (see also GIRAPH-129).

        No much, but can be useful to run tests from a 3rd party project and debug in the giraph sources.

        Show
        Eric Charles added a comment - GIRAPH-131 -source-test-jar.patch allows the deployment of the test-jar sources (see also GIRAPH-129 ). No much, but can be useful to run tests from a 3rd party project and debug in the giraph sources.
        Hide
        Hudson added a comment -

        Integrated in Giraph-trunk-Commit #68 (See https://builds.apache.org/job/Giraph-trunk-Commit/68/)
        GIRAPH-131. enable creation of test-jars to simplify testing in downstream projects. Contributed by André Kelpe.

        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236935
        Files :

        • /incubator/giraph/trunk/CHANGELOG
        • /incubator/giraph/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in Giraph-trunk-Commit #68 (See https://builds.apache.org/job/Giraph-trunk-Commit/68/ ) GIRAPH-131 . enable creation of test-jars to simplify testing in downstream projects. Contributed by André Kelpe. jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1236935 Files : /incubator/giraph/trunk/CHANGELOG /incubator/giraph/trunk/pom.xml
        Hide
        Jakob Homan added a comment -

        I've committed this. Resolving as fixed. Thanks, André!

        Show
        Jakob Homan added a comment - I've committed this. Resolving as fixed. Thanks, André!
        Hide
        Jakob Homan added a comment -

        +1. Tested patch and verified all the tests and infrastructure are now in the new jar. Adding -SNAPSHOT makes a few more files break the 100-char path limit and we get more warnings, but this is expected.

        Show
        Jakob Homan added a comment - +1. Tested patch and verified all the tests and infrastructure are now in the new jar. Adding -SNAPSHOT makes a few more files break the 100-char path limit and we get more warnings, but this is expected.

          People

          • Assignee:
            André Kelpe
            Reporter:
            André Kelpe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development