Uploaded image for project: 'Giraph (Retired)'
  1. Giraph (Retired)
  2. GIRAPH-126

Use Collections.emptyList() in BasicRPCCommunications.java

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Invalid
    • None
    • None
    • None
    • None

    Description

      I am doing some tests with giraph and I am having some memory problems. While I was browsing through the codebase I saw that you are allocating a new ArrayList (which has an underlying array of 10 elements) for each Vertex, that has no Messages to be delivered. That's a waste of memory and time. This patch replaces it with the EMPTY_LIST of the Collections utility class.

      Attachments

        1. GIRAPH-126.patch
          1 kB
          André Kelpe
        2. GIRAPH-126.patch
          1 kB
          André Kelpe
        3. GIRAPH-126.patch
          1 kB
          André Kelpe

        Activity

          People

            fs111 André Kelpe
            fs111 André Kelpe
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: