Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-1230

Fix Netty reconnection issues

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      • The LogOnErrorChannelFutureListener is called when a channel operation was complete and it was checking whether the channel failed, in which case it tried to resend any requests. Doing this required to wait until a channel had been re-established. However, doing a wait operation from the same thread that calls the handler, causes a BlockingOperationException from Netty. So this is not effective.
      • Upon a channel closing, we have logic that will try to re-open the channels doing a max number of retries.. But we also had logic in the ChannelRoterator that would throw an exception if we didn't find any channel. This does not give the opportunity to re-conenct.
      • Whenever the client closes the connection, the server catches this (Connection reset by peer) and throws an exception as well, so the job fails immediately. This does not give the opportunity to the client to re-connect.

        Attachments

          Activity

            People

            • Assignee:
              dlogothetis Dionysios Logothetis
              Reporter:
              dlogothetis Dionysios Logothetis
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: