Giraph
  1. Giraph
  2. GIRAPH-118

Clarify messages behavior in BasicVertex

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 0.1.0
    • Component/s: graph
    • Labels:
      None

      Description

      initialize() can receive a null parameter for messages (at least that's what EdgeListVertex does). We should avoid that and pass an empty Iterable instead. That should be cheap for us inside of the InputFormat, just passing a static immutable empty list.

      setMessages(Iterable<M>) should be changed to putMessages(Iterable<M>). the set prefix suggests an assignment, while setMessages is used to transfer the messages to the internal datastructure the user is responsible for. putMessages() should clarify this.

      1. GIRAPH-118.diff
        4 kB
        Claudio Martella
      2. GIRAPH-119.diff
        4 kB
        Claudio Martella

        Activity

        Jakob Homan made changes -
        Fix Version/s 0.1.0 [ 12317572 ]
        Claudio Martella made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Claudio Martella made changes -
        Attachment GIRAPH-118.diff [ 12509742 ]
        Claudio Martella made changes -
        Attachment GIRAPH-119.diff [ 12509741 ]
        Claudio Martella made changes -
        Field Original Value New Value
        Assignee Claudio Martella [ cmartella ]
        Affects Version/s 0.70.0 [ 12317572 ]
        Description initialize() can receive a null parameter for messages (at least that's what EdgeListVertex does). We should avoid that and pass an empty Iterable instead. That should be cheap for us inside of the InputFormat, just passing a static immutable empty list.

        setMessages(Iterable<M>) should be changed to putMessages(Iterable<M>). the set prefix suggests an assignment, while setMessages is used to transfer the messages to the internal datastructure the user is responsible for. putMessages() should clarify this.
        Claudio Martella created issue -

          People

          • Assignee:
            Claudio Martella
            Reporter:
            Claudio Martella
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development