Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-1157

Allow implementations of JobProgressTrackerService to extend kill job behavior

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user majakabiljo opened a pull request:

        https://github.com/apache/giraph/pull/46

        GIRAPH-1157

        Allow implementations of JobProgressTrackerService to extend kill job behavior

        Test Plan: Ran a job with additional behavior in kill method and verified it's executed

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/majakabiljo/giraph giraph-1157

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/giraph/pull/46.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #46


        commit daadef5be53f8722ff007245c46670128119e534
        Author: Maja Kabiljo <majakabiljo@fb.com>
        Date: 2017-09-07T23:05:20Z

        GIRAPH-1157: Allow implementations of JobProgressTrackerService to extend kill job behavior

        Test Plan: Ran a job with additional behavior in kill method and verified it's executed


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user majakabiljo opened a pull request: https://github.com/apache/giraph/pull/46 GIRAPH-1157 Allow implementations of JobProgressTrackerService to extend kill job behavior Test Plan: Ran a job with additional behavior in kill method and verified it's executed You can merge this pull request into a Git repository by running: $ git pull https://github.com/majakabiljo/giraph giraph-1157 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/giraph/pull/46.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #46 commit daadef5be53f8722ff007245c46670128119e534 Author: Maja Kabiljo <majakabiljo@fb.com> Date: 2017-09-07T23:05:20Z GIRAPH-1157 : Allow implementations of JobProgressTrackerService to extend kill job behavior Test Plan: Ran a job with additional behavior in kill method and verified it's executed
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dlogothetis commented on the issue:

        https://github.com/apache/giraph/pull/46

        Just to be clear, here you want to allow custom behavior based on the type of the kill (i.e. the message), right?

        Looks good too me.

        Show
        githubbot ASF GitHub Bot added a comment - Github user dlogothetis commented on the issue: https://github.com/apache/giraph/pull/46 Just to be clear, here you want to allow custom behavior based on the type of the kill (i.e. the message), right? Looks good too me.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/giraph/pull/46

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/giraph/pull/46

          People

          • Assignee:
            majakabiljo Maja Kabiljo
            Reporter:
            majakabiljo Maja Kabiljo
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development