Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-1151

Avoid message value factory initialization in Apache Giraph

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Messages in Giraph are instantiated using a "message value factory" class. Currently the message value factory gets instantiated every time a message is sent, which is unnecessary and can cause high overhead if the message value factory constructor contains expensive operation. Factory objects are be saved to avoid repeated expensive object creations.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user yukselakinci opened a pull request:

          https://github.com/apache/giraph/pull/42

          Avoid message value factory initialization in Apache Giraph

          Jira ticket id: https://issues.apache.org/jira/browse/GIRAPH-1151

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/yukselakinci/giraph avoidfactoryinit

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/giraph/pull/42.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #42


          commit 1216cde8326753c5a6fafa315cab2d59c7c7d7d0
          Author: Yuksel Akinci <yuksela@fb.com>
          Date: 2017-08-16T23:31:51Z

          Avoid message value factory initialization in Apache Giraph
          Jira ticket id: https://issues.apache.org/jira/browse/GIRAPH-1151


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user yukselakinci opened a pull request: https://github.com/apache/giraph/pull/42 Avoid message value factory initialization in Apache Giraph Jira ticket id: https://issues.apache.org/jira/browse/GIRAPH-1151 You can merge this pull request into a Git repository by running: $ git pull https://github.com/yukselakinci/giraph avoidfactoryinit Alternatively you can review and apply these changes as the patch at: https://github.com/apache/giraph/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 commit 1216cde8326753c5a6fafa315cab2d59c7c7d7d0 Author: Yuksel Akinci <yuksela@fb.com> Date: 2017-08-16T23:31:51Z Avoid message value factory initialization in Apache Giraph Jira ticket id: https://issues.apache.org/jira/browse/GIRAPH-1151
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user yukselakinci closed the pull request at:

          https://github.com/apache/giraph/pull/42

          Show
          githubbot ASF GitHub Bot added a comment - Github user yukselakinci closed the pull request at: https://github.com/apache/giraph/pull/42

            People

            • Assignee:
              Unassigned
              Reporter:
              yukselakinci Yuksel Akinci
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 168h
                168h
                Remaining:
                Remaining Estimate - 168h
                168h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development