Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 3.0
    • Component/s: eclipse-plugin
    • Labels:
    • Environment:
      WinXP sp3 32bit& Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1&SR2

      Description

      1 Provide a UI interface to control all the bundles' start level
      2 Control the specific bundle's start level easily

      1. controlBundleStartLevel_764.patch
        29 kB
        Yi Xiao
      2. defaultStartLevel.jpg
        25 kB
        Yi Xiao
      3. singleStartLevel.jpg
        35 kB
        Yi Xiao
      4. controlBundleStartLevel_764_1.patch
        14 kB
        Yi Xiao
      5. controlBundleStartLevel_764_2.patch
        6 kB
        Yi Xiao

        Activity

        Hide
        Yi Xiao added a comment -

        The patch add a section named "Default OSGI Bundle Start Level" in server page to control all the user bundle's start level, and also, add a menu item when right click the module in servers view named "Change Start Level" to control a single bundle's start level. I will attach pics to show them.

        Show
        Yi Xiao added a comment - The patch add a section named "Default OSGI Bundle Start Level" in server page to control all the user bundle's start level, and also, add a menu item when right click the module in servers view named "Change Start Level" to control a single bundle's start level. I will attach pics to show them.
        Hide
        Jarek Gawor added a comment -

        A few comments:

        1) Make sure you configure your editor to use spaces instead of tabs (per our coding standards).

        2) I'm confused about setting the default start level. It looks like the user can set the default start level in the server configuration in Eclipse but the code also looks up the default start level from the server. And changing the level in Eclipse won't be saved in the server configuration. So I think we have a few options: 1) Eclipse shouldn't be allowed the change the default start level at all or 2) If the default start level is changed in Eclipse it should save the server configuration as well, or 3) make the default start level in Eclipse completely separate from the server's (and be persistent between Eclipse restarts).
        Right now I think my preference would be for option #3.

        3) Don't modify the AriesHelper.BundleInfo. BundleInfo was supposed to be somewhat private to AriesHelper class. Instead maybe rename AriesHelper.BundleInfo to AriesHelper.ProjectInfo (or something like that) and create your own BundleInfo for the OSGiModuleHadler purposes.

        4) Don't forget about the Apache headers for the new files.

        Show
        Jarek Gawor added a comment - A few comments: 1) Make sure you configure your editor to use spaces instead of tabs (per our coding standards). 2) I'm confused about setting the default start level. It looks like the user can set the default start level in the server configuration in Eclipse but the code also looks up the default start level from the server. And changing the level in Eclipse won't be saved in the server configuration. So I think we have a few options: 1) Eclipse shouldn't be allowed the change the default start level at all or 2) If the default start level is changed in Eclipse it should save the server configuration as well, or 3) make the default start level in Eclipse completely separate from the server's (and be persistent between Eclipse restarts). Right now I think my preference would be for option #3. 3) Don't modify the AriesHelper.BundleInfo. BundleInfo was supposed to be somewhat private to AriesHelper class. Instead maybe rename AriesHelper.BundleInfo to AriesHelper.ProjectInfo (or something like that) and create your own BundleInfo for the OSGiModuleHadler purposes. 4) Don't forget about the Apache headers for the new files.
        Hide
        Yi Xiao added a comment -

        Thanks for your comments.
        1&4 I will make the configuration in my editor~
        2 Yes, I agree with your option #3. I will add some descriptions to illustrate that change the default start level will not effect the server side.
        3 I will create the BundleInfo in OSGiModuleHandler and persist the BundleInfo in GEP for more bundle osgi control.

        Show
        Yi Xiao added a comment - Thanks for your comments. 1&4 I will make the configuration in my editor~ 2 Yes, I agree with your option #3. I will add some descriptions to illustrate that change the default start level will not effect the server side. 3 I will create the BundleInfo in OSGiModuleHandler and persist the BundleInfo in GEP for more bundle osgi control.
        Hide
        Yi Xiao added a comment -

        The newest patch is "controlBundleStartLevel_764_1.patch", it depends on the patch of GERONIMODEVTOOLS-759

        Now, the default start level is separated from the server, when the eclipse is shutting down, the value persists to a local file automatically and retrieves when eclipse starts up.

        Show
        Yi Xiao added a comment - The newest patch is "controlBundleStartLevel_764_1.patch", it depends on the patch of GERONIMODEVTOOLS-759 Now, the default start level is separated from the server, when the eclipse is shutting down, the value persists to a local file automatically and retrieves when eclipse starts up.
        Hide
        Han Hong Fang added a comment -

        Committed at revision: 1161030. Thanks Yi Xiao for the patch.

        Show
        Han Hong Fang added a comment - Committed at revision: 1161030. Thanks Yi Xiao for the patch.
        Hide
        Jarek Gawor added a comment -

        Can you please check first if the "change bundle level" popup shows up on any module? It should only show up on bundle projects and only on standalone projects (not part of eba).

        Show
        Jarek Gawor added a comment - Can you please check first if the "change bundle level" popup shows up on any module? It should only show up on bundle projects and only on standalone projects (not part of eba).
        Hide
        Han Hong Fang added a comment -

        Good catch! Thanks Jarek.

        Show
        Han Hong Fang added a comment - Good catch! Thanks Jarek.
        Hide
        Han Hong Fang added a comment -

        Commit the changes at revision: 1161984 to show the popup menu only when the selection is standalone OSGi bundle.

        Show
        Han Hong Fang added a comment - Commit the changes at revision: 1161984 to show the popup menu only when the selection is standalone OSGi bundle.
        Hide
        Han Hong Fang added a comment -

        Change the status to Resolved.

        Show
        Han Hong Fang added a comment - Change the status to Resolved.
        Hide
        Yi Xiao added a comment -

        add a new patch: controlBundleStartLevel_764_2.patch.
        when the server shutdown, could not change the bundle start level, because GEP communicates with server when change it.

        Show
        Yi Xiao added a comment - add a new patch: controlBundleStartLevel_764_2.patch. when the server shutdown, could not change the bundle start level, because GEP communicates with server when change it.
        Hide
        Han Hong Fang added a comment -

        Good supplement, Yi Xiao. Committed at revision: 1172496.

        Show
        Han Hong Fang added a comment - Good supplement, Yi Xiao. Committed at revision: 1172496.

          People

          • Assignee:
            Yi Xiao
            Reporter:
            Yi Xiao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development