Uploaded image for project: 'Geronimo-Devtools'
  1. Geronimo-Devtools
  2. GERONIMODEVTOOLS-171

Add extension point to remove hard-coded org.apache.geronimo name from launch console action check

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.x
    • Fix Version/s: 2.1.3
    • Component/s: eclipse-plugin
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Replace:

      console=Geronimo Console
      consoleTooltip=Apache Geronimo Console

      with:

      console=

      {0} Console
      consoleTooltip={0}

      Console

      in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().

      This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.

      In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch

      {ServerName}

      Console" menu item should be activated.

        Attachments

        1. GD-171.patch
          2 kB
          Ted Kirby

          Activity

            People

            • Assignee:
              tkirby Ted Kirby
              Reporter:
              tkirby Ted Kirby
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: