Geronimo
  1. Geronimo
  2. GERONIMO-659

ejbs should point to TSS bean not TSS to ejb

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: 1.0-M3
    • Fix Version/s: 1.0-M4
    • Component/s: CORBA
    • Labels:
      None

      Description

      Currently the TSS gbeans have a reference collection of ejbs they service. This is extremely unwieldy in practice. The ejb should have a reference to the TSS generated from info in the openejb plan.

        Activity

        Hide
        David Jencks added a comment -

        Implemented. Session and entity beans can have an element after the jndi-name. You get a choice of:

        tss-link (just the name part, we look in the current application and then no-app for a single match)
        tss-name (full object name of tss bean)
        tss (you supply the parts of the tss bean name that differ from the current context)

        Show
        David Jencks added a comment - Implemented. Session and entity beans can have an element after the jndi-name. You get a choice of: tss-link (just the name part, we look in the current application and then no-app for a single match) tss-name (full object name of tss bean) tss (you supply the parts of the tss bean name that differ from the current context)
        Hide
        David Blevins added a comment -

        As strong principle in OpenEJB is that the containers are egnostic to any transport and any one transport is not required to run a container. This particular change breaks that and will have to be revisited.

        Show
        David Blevins added a comment - As strong principle in OpenEJB is that the containers are egnostic to any transport and any one transport is not required to run a container. This particular change breaks that and will have to be revisited.
        Hide
        Alan Cabrera added a comment -

        Now I remember why I originally designed it that way.

        Show
        Alan Cabrera added a comment - Now I remember why I originally designed it that way.
        Hide
        David Jencks added a comment -

        The tss tags are not required, ejbs still work fine without corba.

        I agree the current solution is not optimal.

        I think there is a problem with having the tss bean reference the ejb container, namely that if several tss beans reference the same ejb container, corba won't know what IOR to serve up when you look up that ejb. Having the ejb reference the tss prevents this from happening. Can you suggest another solution to this problem?

        We _might_ be able to alleviate the extreme inconvenience and unworkability of the previous implemenation of the tss bean referring to the ejb by recommending that you include the tss bean you want to use in your application rather than in the standard geronimo config. This would also fix the ridiculous situation that deploying another app requires you to modify the basic geronimo plan in order to access the ejbs.

        Also, the presence of jndi-name and local-jndi-name in EjbContainer seems to me that it is equally injecting information not relevant to the ejb or the geronimo naming system and only relevant to particular transports.

        Show
        David Jencks added a comment - The tss tags are not required, ejbs still work fine without corba. I agree the current solution is not optimal. I think there is a problem with having the tss bean reference the ejb container, namely that if several tss beans reference the same ejb container, corba won't know what IOR to serve up when you look up that ejb. Having the ejb reference the tss prevents this from happening. Can you suggest another solution to this problem? We _ might _ be able to alleviate the extreme inconvenience and unworkability of the previous implemenation of the tss bean referring to the ejb by recommending that you include the tss bean you want to use in your application rather than in the standard geronimo config. This would also fix the ridiculous situation that deploying another app requires you to modify the basic geronimo plan in order to access the ejbs. Also, the presence of jndi-name and local-jndi-name in EjbContainer seems to me that it is equally injecting information not relevant to the ejb or the geronimo naming system and only relevant to particular transports.
        Hide
        David Jencks added a comment -

        This is implemented, and in some ways it is more convenient than the reverse, but it is a mistake. I'm opening a more general issue to track progress on reversing this.

        Show
        David Jencks added a comment - This is implemented, and in some ways it is more convenient than the reverse, but it is a mistake. I'm opening a more general issue to track progress on reversing this.
        Hide
        David Jencks added a comment -

        No point in keeping this open, even though it was sort of a bad idea.

        Show
        David Jencks added a comment - No point in keeping this open, even though it was sort of a bad idea.

          People

          • Assignee:
            David Jencks
            Reporter:
            David Jencks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development