Geronimo
  1. Geronimo
  2. GERONIMO-6373

Expose HOWL flushPartialBuffer config via HOWLLog - useful under low concurrency

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: None
    • Component/s: transaction manager
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      HOWL XALogger supports flushPartialBuffers which is not configurable via Geronimo HOWLLog. It is useful in the case of low concurrency.

      It would be great to have this exposed in the HOWLLog constructor so that it be be configured.

        /**
         * Indicates whether LogBufferManager should flush buffers
         * before they are full.
         * 
         * <p>Normally, buffers are flushed to disk only when
         * they become full.  In lightly loaded situations,
         * one or more threads may have to wait until the
         * flushSleepTime expires before the buffer is written.
         * In the worst case, a single thread is using the
         * log, and every put() with sync requested will
         * be delayed flushSleepTime ms before the buffer is
         * written.
         * 
         * <p>Setting flushPartialBuffers true will allow
         * the LogBufferManager to flush buffers to disk
         * any time the channel is not busy.  This improves
         * throughput in single threaded and lightly loaded
         * environments. 
         * 
         * <p>By default, this feature is disabled (false) to
         * provide compatability with earlier versions of
         * this library.
         */
        private boolean flushPartialBuffers = false;

        Issue Links

          Activity

          Hide
          Gary Tully added a comment -

          Patch that adds new constructor that takes additional flushPartialBuffers arg.

          Show
          Gary Tully added a comment - Patch that adds new constructor that takes additional flushPartialBuffers arg.
          Hide
          David Jencks added a comment -

          Is there a good reason not to just set this to true unilaterally? I wasn't aware of the flag but why would we ever want it false?

          Show
          David Jencks added a comment - Is there a good reason not to just set this to true unilaterally? I wasn't aware of the flag but why would we ever want it false?
          Hide
          Gary Tully added a comment -

          I guess not based on the comment, it is false just for compatibility.

          Show
          Gary Tully added a comment - I guess not based on the comment, it is false just for compatibility.
          Hide
          Guillaume Nodet added a comment -

          Not sure which version I should put. djencks ?

          Show
          Guillaume Nodet added a comment - Not sure which version I should put. djencks ?

            People

            • Assignee:
              Guillaume Nodet
              Reporter:
              Gary Tully
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development