Geronimo
  1. Geronimo
  2. GERONIMO-6340

Can not open "Edit" link of Datasources in admin console when using IE

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0-beta-1
    • Fix Version/s: 3.0.0
    • Component/s: console
    • Security Level: public (Regular issues)
    • Environment:

      Win7 64bit, IE 9, Oracle java 6

    • Patch Info:
      Patch Available

      Description

      Can not open "Edit" link of Datasources in admin console when using IE, it is fine when using Firefox browser.
      This issue occurs in Geronimo v3.0-beta-1 only.

        Activity

        Hide
        Shawn Jiang added a comment -

        Could anyone to run console testsuite test result after this patch applied ? Actually, to run console testsuite before submitting the console related patch would be recommended.

        Show
        Shawn Jiang added a comment - Could anyone to run console testsuite test result after this patch applied ? Actually, to run console testsuite before submitting the console related patch would be recommended.
        Hide
        Forrest Xia added a comment -

        3.0-beta@1332927, trunk@1332928.

        Thanks Saphen for this patch!

        Show
        Forrest Xia added a comment - 3.0-beta@1332927, trunk@1332928. Thanks Saphen for this patch!
        Hide
        Saphen Qiu added a comment -

        Hi Forrest, after debug in code, find that there have much more "%7c" strings contained in 'location' variable in sendRedirect method of PlutoURLRebuildFilter.java, the 'location' variable will be send in a form way which needs the 16 band strings "%7c" to be transferred back to aborignal "|".

        Show
        Saphen Qiu added a comment - Hi Forrest, after debug in code, find that there have much more "%7c" strings contained in 'location' variable in sendRedirect method of PlutoURLRebuildFilter.java, the 'location' variable will be send in a form way which needs the 16 band strings "%7c" to be transferred back to aborignal "|".
        Hide
        Forrest Xia added a comment -

        Hi Saphen, thank you for reporting this and providing this patch. Before we accept it, can you help dig out more why transforming %7c to "|" could fix this issue? Cause it reduce the length? or other reason? Do we need to un-normalize other %xx back its original char representation?

        Show
        Forrest Xia added a comment - Hi Saphen, thank you for reporting this and providing this patch. Before we accept it, can you help dig out more why transforming %7c to "|" could fix this issue? Cause it reduce the length? or other reason? Do we need to un-normalize other %xx back its original char representation?
        Hide
        Saphen Qiu added a comment -

        The 'edit' URL in datasources is too long and exceeds 1900 defined in PlutoURLRebuildFilter.java, then it will automatically use post method to send the request, but the location url includes some escape chars "%7C", translates them to "|", and the edit link works.

        Show
        Saphen Qiu added a comment - The 'edit' URL in datasources is too long and exceeds 1900 defined in PlutoURLRebuildFilter.java, then it will automatically use post method to send the request, but the location url includes some escape chars "%7C", translates them to "|", and the edit link works.

          People

          • Assignee:
            Saphen Qiu
            Reporter:
            Saphen Qiu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development