Geronimo
  1. Geronimo
  2. GERONIMO-6309

The usage of ConfiguredEncryption is wrong in the comment block

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Later
    • Affects Version/s: 2.1.7, 2.1.8
    • Fix Version/s: None
    • Component/s: general
    • Security Level: public (Regular issues)
    • Environment:
    • Patch Info:
      Patch Available

      Description

      The description of ConfiguredEncryption usage is wrong:

      • <gbean name="ConfiguredEncryption">
      • <attribute name="path">var/security/ConfiguredSecretKey.ser</attribute>
      • <reference name="ServerInfo"><pattern><name>ServerInfo</name></pattern></reference>
      • </gbean>

      Here is the correct one:

      • <gbean name="org.apache.geronimo.framework/rmi-naming/2.1.8/car?j2eeType=GBean,name=ConfiguredEncryption" gbeanInfo="org.apache.geronimo.system.util.ConfiguredEncryption">
      • <attribute name="path">var/security/ConfiguredSecretKey.ser</attribute>
      • <reference name="ServerInfo">
      • <pattern>
      • <name>ServerInfo</name>
      • </pattern>
      • </reference>
      • </gbean>

        Activity

        Saphen Qiu created issue -
        Saphen Qiu made changes -
        Field Original Value New Value
        Attachment ConfiguredEncryption.patch [ 12520104 ]
        Saphen Qiu made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Saphen Qiu made changes -
        Status In Progress [ 3 ] Open [ 1 ]
        Saphen Qiu made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Saphen Qiu made changes -
        Status In Progress [ 3 ] Open [ 1 ]
        Hide
        Forrest Xia added a comment -

        Saphen, pls help make this patch against Geronimo, also need patches for 2.2, 3.0-beta, and trunk. thank you!

        Show
        Forrest Xia added a comment - Saphen, pls help make this patch against Geronimo, also need patches for 2.2, 3.0-beta, and trunk. thank you!
        Saphen Qiu made changes -
        Affects Version/s 3.0-M1 [ 12315090 ]
        Affects Version/s 3.0-beta-1 [ 12318841 ]
        Description The description of ConfiguredEncryption usage is wrong:

        * <gbean name="ConfiguredEncryption">
        * <attribute name="path">var/security/ConfiguredSecretKey.ser</attribute>
        * <reference name="ServerInfo"><pattern><name>ServerInfo</name></pattern></reference>
        * </gbean>

        Here is the correct one:

         * <gbean name="org.apache.geronimo.framework/rmi-naming/2.1.8-wasce/car?j2eeType=GBean,name=ConfiguredEncryption" gbeanInfo="org.apache.geronimo.system.util.ConfiguredEncryption">
         * <attribute name="path">var/security/ConfiguredSecretKey.ser</attribute>
         * <reference name="ServerInfo">
         * <pattern>
         * <name>ServerInfo</name>
         * </pattern>
         * </reference>
         * </gbean>
        The description of ConfiguredEncryption usage is wrong:

        * <gbean name="ConfiguredEncryption">
        * <attribute name="path">var/security/ConfiguredSecretKey.ser</attribute>
        * <reference name="ServerInfo"><pattern><name>ServerInfo</name></pattern></reference>
        * </gbean>

        Here is the correct one:

         * <gbean name="org.apache.geronimo.framework/rmi-naming/2.1.8/car?j2eeType=GBean,name=ConfiguredEncryption" gbeanInfo="org.apache.geronimo.system.util.ConfiguredEncryption">
         * <attribute name="path">var/security/ConfiguredSecretKey.ser</attribute>
         * <reference name="ServerInfo">
         * <pattern>
         * <name>ServerInfo</name>
         * </pattern>
         * </reference>
         * </gbean>
        Saphen Qiu made changes -
        Attachment ConfiguredEncryption.patch [ 12520104 ]
        Hide
        Saphen Qiu added a comment -

        Forrest, sorry for this mistake.
        After checking 3.0-beta and trunk, the description in comment block is right, but in geronimo 2.x it is wrong.
        I will attach a patch against geronimo v2.1.8.

        Show
        Saphen Qiu added a comment - Forrest, sorry for this mistake. After checking 3.0-beta and trunk, the description in comment block is right, but in geronimo 2.x it is wrong. I will attach a patch against geronimo v2.1.8.
        Saphen Qiu made changes -
        Attachment ConfiguredEncryption.java.patch [ 12525399 ]
        Hide
        Forrest Xia added a comment -

        If the patch is to fix the comment description, then we need to blur the version number and tell the user the version should be updated according to the geronimo version they are using.

        Please revise this patch, thank you!

        Show
        Forrest Xia added a comment - If the patch is to fix the comment description, then we need to blur the version number and tell the user the version should be updated according to the geronimo version they are using. Please revise this patch, thank you!
        Saphen Qiu made changes -
        Attachment ConfiguredEncryption.java.patch [ 12525399 ]
        Hide
        Saphen Qiu added a comment -

        Revise patch with adding

        {version}

        instead of 2.1

        Show
        Saphen Qiu added a comment - Revise patch with adding {version} instead of 2.1
        Saphen Qiu made changes -
        Attachment ConfiguredEncryption.java.patch [ 12525553 ]
        Hide
        Forrest Xia added a comment -

        Can we close this jira and merge this patch into 6310? btw, I cannot apply this patch to 3.0-beta branch. thanks!

        Show
        Forrest Xia added a comment - Can we close this jira and merge this patch into 6310? btw, I cannot apply this patch to 3.0-beta branch. thanks!
        Hide
        Saphen Qiu added a comment -

        Will merge this fix to Geronimo-6310

        Show
        Saphen Qiu added a comment - Will merge this fix to Geronimo-6310
        Saphen Qiu made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.1.8 [ 12315918 ]
        Resolution Later [ 7 ]
        Saphen Qiu made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        xiezhi added a comment -

        Could anyone tell me how to create the file named ConfiguredSecretKey.ser. I create it myself. But it will meet the exception below when you start the server.

        [** ] 7% 1s Loading rmi-naming 2012-09-13 17:22:00,806 ERROR [GBeanInst
        anceState] Error while starting; GBean is now in the FAILED state: abstractName="org.apache.geronimo.framework/rmi-naming/3.0-w20120503/car?j2eeType=G
        Bean,name=ConfiguredEncryption"
        java.io.StreamCorruptedException: invalid stream header: FEEDFEED
        at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:786)
        at java.io.ObjectInputStream.<init>(ObjectInputStream.java:283)
        at org.apache.geronimo.system.util.ConfiguredEncryption.<init>(ConfiguredEncryption.java:64)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:44)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:516)
        at org.apache.xbean.recipe.ReflectionUtil$ConstructorFactory.create(ReflectionUtil.java:958)
        at org.apache.xbean.recipe.ObjectRecipe.internalCreate(ObjectRecipe.java:276)
        at org.apache.xbean.recipe.AbstractRecipe.create(AbstractRecipe.java:96)
        at org.apache.xbean.recipe.AbstractRecipe.create(AbstractRecipe.java:61)
        at org.apache.geronimo.gbean.runtime.GBeanInstance.createInstance(GBeanInstance.java:958)
        at org.apache.geronimo.gbean.runtime.GBeanInstanceState.attemptFullStart(GBeanInstanceState.java:271)
        at org.apache.geronimo.gbean.runtime.GBeanInstanceState.start(GBeanInstanceState.java:105)
        at org.apache.geronimo.gbean.runtime.GBeanInstanceState.startRecursive(GBeanInstanceState.java:127)
        at org.apache.geronimo.gbean.runtime.GBeanInstance.startRecursive(GBeanInstance.java:569)
        at org.apache.geronimo.kernel.basic.BasicKernel.startRecursiveGBean(BasicKernel.java:386)
        at org.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:462)
        at org.apache.geronimo.kernel.config.KernelConfigurationManager.start(KernelConfigurationManager.java:226)
        at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:702)
        at org.apache.geronimo.system.main.EmbeddedDaemon.doStartup(EmbeddedDaemon.java:213)
        at org.apache.geronimo.system.main.EmbeddedDaemon.execute(EmbeddedDaemon.java:93)
        at org.apache.geronimo.system.osgi.BootActivator$1.execute(BootActivator.java:107)
        at org.apache.geronimo.main.Bootstrapper.execute(Bootstrapper.java:67)
        at org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:65)
        at org.apache.geronimo.cli.daemon.DaemonCLI.main(DaemonCLI.java:32)
        [** ] 7% 1s Startup failed
        org.apache.geronimo.kernel.config.LifecycleException: start of org.apache.geronimo.framework/rmi-naming/3.0-w20110721/car failed
        at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:718)
        at org.apache.geronimo.system.main.EmbeddedDaemon.doStartup(EmbeddedDaemon.java:213)
        at org.apache.geronimo.system.main.EmbeddedDaemon.execute(EmbeddedDaemon.java:93)
        at org.apache.geronimo.system.osgi.BootActivator$1.execute(BootActivator.java:107)
        at org.apache.geronimo.main.Bootstrapper.execute(Bootstrapper.java:67)
        at org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:65)
        at org.apache.geronimo.cli.daemon.DaemonCLI.main(DaemonCLI.java:32)
        Caused by: org.apache.geronimo.kernel.config.InvalidConfigException: Unknown start exception
        at org.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:523)
        at org.apache.geronimo.kernel.config.KernelConfigurationManager.start(KernelConfigurationManager.java:226)
        at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:702)
        ... 6 more

        Show
        xiezhi added a comment - Could anyone tell me how to create the file named ConfiguredSecretKey.ser. I create it myself. But it will meet the exception below when you start the server. [** ] 7% 1s Loading rmi-naming 2012-09-13 17:22:00,806 ERROR [GBeanInst anceState] Error while starting; GBean is now in the FAILED state: abstractName="org.apache.geronimo.framework/rmi-naming/3.0-w20120503/car?j2eeType=G Bean,name=ConfiguredEncryption" java.io.StreamCorruptedException: invalid stream header: FEEDFEED at java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:786) at java.io.ObjectInputStream.<init>(ObjectInputStream.java:283) at org.apache.geronimo.system.util.ConfiguredEncryption.<init>(ConfiguredEncryption.java:64) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:44) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27) at java.lang.reflect.Constructor.newInstance(Constructor.java:516) at org.apache.xbean.recipe.ReflectionUtil$ConstructorFactory.create(ReflectionUtil.java:958) at org.apache.xbean.recipe.ObjectRecipe.internalCreate(ObjectRecipe.java:276) at org.apache.xbean.recipe.AbstractRecipe.create(AbstractRecipe.java:96) at org.apache.xbean.recipe.AbstractRecipe.create(AbstractRecipe.java:61) at org.apache.geronimo.gbean.runtime.GBeanInstance.createInstance(GBeanInstance.java:958) at org.apache.geronimo.gbean.runtime.GBeanInstanceState.attemptFullStart(GBeanInstanceState.java:271) at org.apache.geronimo.gbean.runtime.GBeanInstanceState.start(GBeanInstanceState.java:105) at org.apache.geronimo.gbean.runtime.GBeanInstanceState.startRecursive(GBeanInstanceState.java:127) at org.apache.geronimo.gbean.runtime.GBeanInstance.startRecursive(GBeanInstance.java:569) at org.apache.geronimo.kernel.basic.BasicKernel.startRecursiveGBean(BasicKernel.java:386) at org.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:462) at org.apache.geronimo.kernel.config.KernelConfigurationManager.start(KernelConfigurationManager.java:226) at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:702) at org.apache.geronimo.system.main.EmbeddedDaemon.doStartup(EmbeddedDaemon.java:213) at org.apache.geronimo.system.main.EmbeddedDaemon.execute(EmbeddedDaemon.java:93) at org.apache.geronimo.system.osgi.BootActivator$1.execute(BootActivator.java:107) at org.apache.geronimo.main.Bootstrapper.execute(Bootstrapper.java:67) at org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:65) at org.apache.geronimo.cli.daemon.DaemonCLI.main(DaemonCLI.java:32) [** ] 7% 1s Startup failed org.apache.geronimo.kernel.config.LifecycleException: start of org.apache.geronimo.framework/rmi-naming/3.0-w20110721/car failed at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:718) at org.apache.geronimo.system.main.EmbeddedDaemon.doStartup(EmbeddedDaemon.java:213) at org.apache.geronimo.system.main.EmbeddedDaemon.execute(EmbeddedDaemon.java:93) at org.apache.geronimo.system.osgi.BootActivator$1.execute(BootActivator.java:107) at org.apache.geronimo.main.Bootstrapper.execute(Bootstrapper.java:67) at org.apache.geronimo.cli.AbstractCLI.executeMain(AbstractCLI.java:65) at org.apache.geronimo.cli.daemon.DaemonCLI.main(DaemonCLI.java:32) Caused by: org.apache.geronimo.kernel.config.InvalidConfigException: Unknown start exception at org.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:523) at org.apache.geronimo.kernel.config.KernelConfigurationManager.start(KernelConfigurationManager.java:226) at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:702) ... 6 more

          People

          • Assignee:
            Saphen Qiu
            Reporter:
            Saphen Qiu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development