Geronimo
  1. Geronimo
  2. GERONIMO-6296

Add a test case to validate ConnectorGBean way is still deployable via application deployment

    Details

    • Type: Task Task
    • Status: In Progress
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: testsuite
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      We need a test case to validate the GBean way defining the Tomcat Connector is still valid when deploying an application.

        Activity

        Hide
        xiezhi added a comment -

        Have updated the version.

        Show
        xiezhi added a comment - Have updated the version.
        Hide
        Forrest Xia added a comment -

        Gary, the pom version seems not correct, please rework a new patch and ensure it's for 3.0-beta branch. thank you!

        Show
        Forrest Xia added a comment - Gary, the pom version seems not correct, please rework a new patch and ensure it's for 3.0-beta branch. thank you!
        Hide
        xiezhi added a comment -

        Hi,have do some update to follow your advice. Thank you very much!

        Show
        xiezhi added a comment - Hi,have do some update to follow your advice. Thank you very much!
        Hide
        Forrest Xia added a comment -

        xiezhi,

        Thank you for providing this patch, it looks good, but before committing it, can you make these changes?
        1. Refractor the ClassViewerServlet.java and use o.a.g as the package name
        2. Add the ASF v2.0 license header to all files included in the patch. You can use "mvn rat:check" to do a check.

        Thanks again for your contribution!

        Forrest

        Show
        Forrest Xia added a comment - xiezhi, Thank you for providing this patch, it looks good, but before committing it, can you make these changes? 1. Refractor the ClassViewerServlet.java and use o.a.g as the package name 2. Add the ASF v2.0 license header to all files included in the patch. You can use "mvn rat:check" to do a check. Thanks again for your contribution! Forrest
        Hide
        xiezhi added a comment -

        I add a test case to validate ConnectorGBean.

        Show
        xiezhi added a comment - I add a test case to validate ConnectorGBean.

          People

          • Assignee:
            xiezhi
            Reporter:
            Forrest Xia
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development