Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: commands
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      deploy:install-bundle
      deploy:uninstall-bundle

      should be supported via Karaf shell in Geronimo.

      1. GERONIMO-6075-updated.patch
        7 kB
        Rex Wang
      2. 6075.patch
        7 kB
        Chi Runhua

        Activity

        Chi Runhua created issue -
        Chi Runhua made changes -
        Field Original Value New Value
        Fix Version/s 3.0 [ 12314206 ]
        Chi Runhua made changes -
        Attachment 6075.patch [ 12486285 ]
        Rex Wang made changes -
        Attachment GERONIMO-6075-updated.patch [ 12486313 ]
        Hide
        Rex Wang added a comment -

        hi Jeff, thanks for the patch!
        I made a updated patch based on yours. There are a little bit issues:
        1. the java coding convention requires the variable name should start with a lower case character.
        eg: "String bundleId", not "String BundleId"
        2. use 4 spaces to replace the Tab in the xml.

        You could review and try commit

        -Rex

        Show
        Rex Wang added a comment - hi Jeff, thanks for the patch! I made a updated patch based on yours. There are a little bit issues: 1. the java coding convention requires the variable name should start with a lower case character. eg: "String bundleId", not "String BundleId" 2. use 4 spaces to replace the Tab in the xml. You could review and try commit -Rex
        Hide
        Ivan added a comment -

        Hi, Jeff, I might miss some background info here, since there are commands like osgi:install and osgi:uninstall, why do we need another commands with the similar functions ?

        Show
        Ivan added a comment - Hi, Jeff, I might miss some background info here, since there are commands like osgi:install and osgi:uninstall, why do we need another commands with the similar functions ?
        Hide
        Ivan added a comment -

        OK, I guess that this commands support to persistent the bundle info, so that it will start after the clear cache.

        Show
        Ivan added a comment - OK, I guess that this commands support to persistent the bundle info, so that it will start after the clear cache.
        Hide
        Chi Runhua added a comment - - edited

        Hi Ivan, you mean refer to GERONIMO-5764 for the details. IIUC, the logic of those 2 commands is to persist the bundle in Geronimo repository and record its information in /etc/startup.properties file after installation, then remove the record after uninstallation. In this way, the bundle could survive a clean start. Rex had already implemented the feature in GERONIMO-5764.

        This JIRA is to simply enable the commands for Karaf shell.

        HTH.

        Show
        Chi Runhua added a comment - - edited Hi Ivan, you mean refer to GERONIMO-5764 for the details. IIUC, the logic of those 2 commands is to persist the bundle in Geronimo repository and record its information in /etc/startup.properties file after installation, then remove the record after uninstallation. In this way, the bundle could survive a clean start. Rex had already implemented the feature in GERONIMO-5764 . This JIRA is to simply enable the commands for Karaf shell. HTH.
        Hide
        Chi Runhua added a comment -

        Committed revision 1146091.

        Show
        Chi Runhua added a comment - Committed revision 1146091.
        Chi Runhua made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        5h 54m 1 Chi Runhua 13/Jul/11 16:26

          People

          • Assignee:
            Chi Runhua
            Reporter:
            Chi Runhua
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development