Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: console
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      in the admin console there is a portlet for searching the osgi bundles but
      the search filter is case sensitive and there is no way to turn it off or on

        Issue Links

          Activity

          Hide
          Rex Wang added a comment -

          add Shawn's comments.

          Some imporvement needed for OSGi portlet:

          1. the search filter is case sensitive and there is no way to turn it off or on
          2. searching is really slow
          3, the layout is not so good. I think the bundle info table should be pure html table instead of clickable dojo table widget.

          Show
          Rex Wang added a comment - add Shawn's comments. Some imporvement needed for OSGi portlet: 1. the search filter is case sensitive and there is no way to turn it off or on 2. searching is really slow 3, the layout is not so good. I think the bundle info table should be pure html table instead of clickable dojo table widget.
          Hide
          Rex Wang added a comment -

          fix #1 and #3 at rev 1061591
          For #3, I made the content selectable, is that what you want?

          For#2, I plan add a button instead of triggering the search by key-up event, is that acceptable?

          -Rex

          Show
          Rex Wang added a comment - fix #1 and #3 at rev 1061591 For #3, I made the content selectable, is that what you want? For#2, I plan add a button instead of triggering the search by key-up event, is that acceptable? -Rex
          Hide
          Rex Wang added a comment - - edited

          commit fix at rev 1063169 to resolve #2

          besides, I make the list descending so that the new installed bundle will be on the top of the list at rev1063173
          -Rex

          Show
          Rex Wang added a comment - - edited commit fix at rev 1063169 to resolve #2 besides, I make the list descending so that the new installed bundle will be on the top of the list at rev1063173 -Rex
          Hide
          Jarek Gawor added a comment -

          I think the portlet might need a complete redesign:

          1) The page showing the osgi bundles must be fast. The current implementation using dojo seems to be very slow (not sure if the problem is in dojo or how we use it in Geronimo). I believe a simple html based table should be sufficient as long as we can still select and perform actions on multiple bundles at once.

          2) Would be good to see (besides the headers): a) services registered by the bundle, 2) services in use, 2) wired bundles

          3) Would be nice to see whenever a bundle is references from services in use or wired bundles that the user could kick on it and that the same info for that bundle as well.

          4) Ensure that bundles that are not real bundles are displayed in the same way as in karaf shell. That is, show the location as the symbolic name instead of "..."

          5) Optionally, include blueprint status (and/or error message).

          Show
          Jarek Gawor added a comment - I think the portlet might need a complete redesign: 1) The page showing the osgi bundles must be fast. The current implementation using dojo seems to be very slow (not sure if the problem is in dojo or how we use it in Geronimo). I believe a simple html based table should be sufficient as long as we can still select and perform actions on multiple bundles at once. 2) Would be good to see (besides the headers): a) services registered by the bundle, 2) services in use, 2) wired bundles 3) Would be nice to see whenever a bundle is references from services in use or wired bundles that the user could kick on it and that the same info for that bundle as well. 4) Ensure that bundles that are not real bundles are displayed in the same way as in karaf shell. That is, show the location as the symbolic name instead of "..." 5) Optionally, include blueprint status (and/or error message).
          Hide
          Jarek Gawor added a comment -

          More problems discovered with the portlet:

          1) There are some refresh problems and sometimes the widget shows bundles that have been uninstalled. And clicking on such items generates a NPE.

          2) Trying to perform start or stop operation on multiple bundles at once sometimes leads to "timeout when process action" error (within 10 seconds or so). The way I can re-create this problem is if one of the bundles is a large bundle, e.g. 50 MB or so.

          Show
          Jarek Gawor added a comment - More problems discovered with the portlet: 1) There are some refresh problems and sometimes the widget shows bundles that have been uninstalled. And clicking on such items generates a NPE. 2) Trying to perform start or stop operation on multiple bundles at once sometimes leads to "timeout when process action" error (within 10 seconds or so). The way I can re-create this problem is if one of the bundles is a large bundle, e.g. 50 MB or so.
          Hide
          Rex Wang added a comment -

          >I think the portlet might need a complete redesign:

          >1) The page showing the osgi bundles must be fast. The current implementation using dojo seems to be very slow (not sure if the problem is in dojo or how we use it in Geronimo). I believe a simple html based table should be sufficient as long as we can still select and perform actions on multiple bundles at once.

          Yes, the dojo data grid is pretty slow. I will upgrade the dojo first and see if the performance has any improvement in the higher version. If not, will try redesign the portlet to find if there is more effective way. I afraid a pure html table is hard to implement the data/view separation, so will consider it if no other better choice.

          >2) Would be good to see (besides the headers): a) services registered by the bundle, 2) services in use, 2) wired bundles

          Yes. These new features are in my todo list

          >3) Would be nice to see whenever a bundle is references from services in use or wired bundles that the user could kick on it and that the same info for that bundle as well.

          OK.

          >4) Ensure that bundles that are not real bundles are displayed in the same way as in karaf shell. That is, show the location as the symbolic name instead of "..."

          OK

          >5) Optionally, include blueprint status (and/or error message).

          will do.

          thanks,

          -Rex

          Show
          Rex Wang added a comment - >I think the portlet might need a complete redesign: >1) The page showing the osgi bundles must be fast. The current implementation using dojo seems to be very slow (not sure if the problem is in dojo or how we use it in Geronimo). I believe a simple html based table should be sufficient as long as we can still select and perform actions on multiple bundles at once. Yes, the dojo data grid is pretty slow. I will upgrade the dojo first and see if the performance has any improvement in the higher version. If not, will try redesign the portlet to find if there is more effective way. I afraid a pure html table is hard to implement the data/view separation, so will consider it if no other better choice. >2) Would be good to see (besides the headers): a) services registered by the bundle, 2) services in use, 2) wired bundles Yes. These new features are in my todo list >3) Would be nice to see whenever a bundle is references from services in use or wired bundles that the user could kick on it and that the same info for that bundle as well. OK. >4) Ensure that bundles that are not real bundles are displayed in the same way as in karaf shell. That is, show the location as the symbolic name instead of "..." OK >5) Optionally, include blueprint status (and/or error message). will do. thanks, -Rex
          Hide
          Shawn Jiang added a comment -

          Is reusing the osgi web console from felix an option ?

          Show
          Shawn Jiang added a comment - Is reusing the osgi web console from felix an option ?
          Hide
          Rex Wang added a comment -

          commit to trunk at rev1073346
          commit to 3.0_M2 at rev1073353
          changes are:
          1. try improve the performance of dojo
          2. show wired bundles
          3. show the location as the symbolic name instead of "..." if it is not real bundle

          Show
          Rex Wang added a comment - commit to trunk at rev1073346 commit to 3.0_M2 at rev1073353 changes are: 1. try improve the performance of dojo 2. show wired bundles 3. show the location as the symbolic name instead of "..." if it is not real bundle
          Hide
          Jarek Gawor added a comment -

          Can you please look into the "time out" issue I reported on the 9th?

          Show
          Jarek Gawor added a comment - Can you please look into the "time out" issue I reported on the 9th?
          Hide
          Rex Wang added a comment -

          Sure. This timeout info is set in the page javascript to hide the loading div (~10s). It's not the start/stop time out. So, will your test bundle(~50M) be started successfully after you see the timeout info? If so, how long does it cost? I am thinking increasing the threshold time but not sure what's the appropriate value.

          Show
          Rex Wang added a comment - Sure. This timeout info is set in the page javascript to hide the loading div (~10s). It's not the start/stop time out. So, will your test bundle(~50M) be started successfully after you see the timeout info? If so, how long does it cost? I am thinking increasing the threshold time but not sure what's the appropriate value.
          Hide
          Rex Wang added a comment -

          improve the timeout codes
          at r1074390 for trunk
          at r1074391 for 3.0_M2

          Could you please have a test with the ~50M bundle?

          thanks
          -Rex

          Show
          Rex Wang added a comment - improve the timeout codes at r1074390 for trunk at r1074391 for 3.0_M2 Could you please have a test with the ~50M bundle? thanks -Rex
          Hide
          Chi Runhua added a comment -

          Found several problems on OSGi portlet FYR.

          1. the layout of buttons should be resized according to the size of the window;
          2. Filter by Symbolic Name function does not work, at least on my firefox 3.6.13;
          3. If I click the Click here twice, the portlet freezes for nearly 60 seconds.
          4. start level of a newly installed bundle can not be specified, is there any reason the feature is removed?

          Thanks~!

          Jeff

          Show
          Chi Runhua added a comment - Found several problems on OSGi portlet FYR. 1. the layout of buttons should be resized according to the size of the window; 2. Filter by Symbolic Name function does not work, at least on my firefox 3.6.13; 3. If I click the Click here twice, the portlet freezes for nearly 60 seconds. 4. start level of a newly installed bundle can not be specified, is there any reason the feature is removed? Thanks~! Jeff
          Hide
          Rex Wang added a comment -

          Hi Jeff, thank you for your comments
          fixed 1 and 3
          in trunk at rev 1076136
          in 3.0_M2 at rev 1076137

          for #2, I tested it in IE/FF/Chrome, it works well..

          Show
          Rex Wang added a comment - Hi Jeff, thank you for your comments fixed 1 and 3 in trunk at rev 1076136 in 3.0_M2 at rev 1076137 for #2, I tested it in IE/FF/Chrome, it works well..
          Hide
          Rex Wang added a comment -

          fix #4 in trunk at rev 1076226
          in 3.0_M2 at rev 1076227

          Show
          Rex Wang added a comment - fix #4 in trunk at rev 1076226 in 3.0_M2 at rev 1076227
          Hide
          Rex Wang added a comment -

          won't continue the improvements for dojo based osgi portlet.
          I opened GERONIMO-5847 for new pure html osgi portlet

          will close this jira.

          -Rex

          Show
          Rex Wang added a comment - won't continue the improvements for dojo based osgi portlet. I opened GERONIMO-5847 for new pure html osgi portlet will close this jira. -Rex
          Hide
          Rex Wang added a comment -

          any new requirement, please post in GERONIMO-5847

          Show
          Rex Wang added a comment - any new requirement, please post in GERONIMO-5847

            People

            • Assignee:
              Rex Wang
              Reporter:
              Rex Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development