Geronimo
  1. Geronimo
  2. GERONIMO-5762

Some dirty files in the root of server code tree after built, they cannot be cleaned by mvn clean

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: buildsystem
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      I see some dirty files in the root directory of server code tree after built, such as
      derby.log
      velocity.log
      var/

      I think these build output files should be in certain target directory, so that maven can clean them when execute "mvn clean".

      1. GERONIMO-5762-noversion.patch
        1 kB
        Shenghao Fang
      2. GERONIMO-5762-241.patch
        1 kB
        Shenghao Fang

        Activity

        Forrest Xia created issue -
        Hide
        Shenghao Fang added a comment -

        The issue can also be solve by adding configurations to 'maven-clean-plugin'. Please refer to the patches.

        Known issue:
        When using maven 3.0.1, the maven-clean-plugin (version is 2.3) runs very slowly. The latest version (2.4.1) has no performance issue.

        Show
        Shenghao Fang added a comment - The issue can also be solve by adding configurations to 'maven-clean-plugin'. Please refer to the patches. Known issue: When using maven 3.0.1, the maven-clean-plugin (version is 2.3) runs very slowly. The latest version (2.4.1) has no performance issue.
        Shenghao Fang made changes -
        Field Original Value New Value
        Attachment GERONIMO-5762-241.patch [ 12468734 ]
        Attachment GERONIMO-5762-noversion.patch [ 12468733 ]
        Hide
        Forrest Xia added a comment -

        Though the patch is a way to get rid of the dirty files, but I prefer to find a way to put those files in the target directory.

        Show
        Forrest Xia added a comment - Though the patch is a way to get rid of the dirty files, but I prefer to find a way to put those files in the target directory.
        Forrest Xia committed 1097653 (1 file)
        Reviews: none

        GERONIMO-5762 clean dirty files during build, though it's not an ideal solution, patch provided by Shenghao Fang

        Hide
        Forrest Xia added a comment -

        commit to trunk@1097653, close it.

        Show
        Forrest Xia added a comment - commit to trunk@1097653, close it.
        Forrest Xia made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 3.0 [ 12314206 ]
        Resolution Fixed [ 1 ]
        Hide
        Shenghao Fang added a comment -

        There are performance issues with the 'noversion' patch.

        And some dirty files in the sub folder are still not removed.

        A more robust solution is needed.

        Please revert the current changes, thanks.

        Show
        Shenghao Fang added a comment - There are performance issues with the 'noversion' patch. And some dirty files in the sub folder are still not removed. A more robust solution is needed. Please revert the current changes, thanks.
        Shenghao Fang made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Assignee Shenghao Fang [ michael_fang ]
        Forrest Xia made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]

          People

          • Assignee:
            Shenghao Fang
            Reporter:
            Forrest Xia
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development