Geronimo
  1. Geronimo
  2. GERONIMO-5440

Dos line endings (^M) makes all unix shell scripts unexecutable

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.1.6
    • Fix Version/s: None
    • Component/s: commands
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      Ubuntu 10.04
      Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
      Geronimo 2.1.6 jetty6 javaee5 2.1.6

      Description

      All shell scripts in geronimo 2.1.6 jetty6 version 2.1.6 seems to have been encoded with dos line endings, which makes them unexecutable:

      Download geronimo-jetty6-javaee5-2.1.6-bin.tar.gz

      tar xvf geronimo-jetty6-javaee5-2.1.6-bin.tar.gz
      cd geronimo-jetty6-javaee5-2.1.6
      bin/startup.sh
      bash: bin/startup.sh: /bin/sh^M: bad interpreter: No such file or directory

      The issue is easily fixable though, convert all dos line endings to unix line endings:

      perl -pi -e 's/\r\n/\n/g' bin/*.sh

      PS. In geronimo's jira version 2.1.6 is not available in the "Affects version/s" option.

        Activity

        Fredrik Jonson created issue -
        Hide
        Kevan Miller added a comment -

        Ugh. Thanks Frederik.

        Another work-around is to build from source.

        We need to fix this issue going forward in future releases. I can think of several options:

        1) build releases on non windows machines
        2) use svn properties to set script/bat files to appropriate line endings
        3) other build trickery (IIRC, we used to mess with line endings based on the distribution type .zip or .tar.gz)
        4) ...

        Any suggestions? Anybody willing to fix?

        Show
        Kevan Miller added a comment - Ugh. Thanks Frederik. Another work-around is to build from source. We need to fix this issue going forward in future releases. I can think of several options: 1) build releases on non windows machines 2) use svn properties to set script/bat files to appropriate line endings 3) other build trickery (IIRC, we used to mess with line endings based on the distribution type .zip or .tar.gz) 4) ... Any suggestions? Anybody willing to fix?
        Kevan Miller made changes -
        Field Original Value New Value
        Affects Version/s 2.1.6 [ 12314972 ]
        Affects Version/s 2.1 [ 12312602 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Fredrik Jonson
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development