Geronimo
  1. Geronimo
  2. GERONIMO-5164

Incomplete feature for deploy:new-instance command in geronimo3.0

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: commands
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      Windows XP

      Description

      "deploy/new-instance" Command in geronimo previous version just copy var folder.
      In G30 with karaf, bin, etc, data, repository also need copied or created in new instance folder.

      1. start new-instance-server command_30.patch
        9 kB
        Vanessa Wang
      2. new-instance 30.patch
        5 kB
        Vanessa Wang

        Issue Links

          Activity

          Vanessa Wang created issue -
          Vanessa Wang made changes -
          Field Original Value New Value
          Component/s commands [ 12312293 ]
          Vanessa Wang made changes -
          Attachment new-instance 30.patch [ 12437695 ]
          Attachment start new-instance-server command_30.patch [ 12437696 ]
          Shawn Jiang made changes -
          Assignee Shawn Jiang [ genspring ]
          Hide
          Shawn Jiang added a comment -

          I guess we only need etc and var to create a new instance.

          Show
          Shawn Jiang added a comment - I guess we only need etc and var to create a new instance.
          Vanessa Wang made changes -
          Attachment new-instance 30.patch [ 12437695 ]
          Hide
          Vanessa Wang added a comment -

          Agree. But repository folder still needed by karaf in order to startup.

          Show
          Vanessa Wang added a comment - Agree. But repository folder still needed by karaf in order to startup.
          Vanessa Wang made changes -
          Attachment new-instance 30.patch [ 12437839 ]
          Hide
          Shawn Jiang added a comment -

          I can't see the value of this when we have to copy all the big artifacts to create a new instance.

          Show
          Shawn Jiang added a comment - I can't see the value of this when we have to copy all the big artifacts to create a new instance.
          Russell E Glaue made changes -
          Link This issue is duplicated by GERONIMO-5988 [ GERONIMO-5988 ]
          Hide
          Russell E Glaue added a comment -

          GERONIMO-5988 duplicates this issue.

          A new instance requires var, etc, and repository else it won't start up.
          The documented method is a straight copy of these directories to the instance directory.

          A problem with this method is if the directories being copied have already been modified from a separate run-time execution. deploy:new-instance would only copy the directories instead of generating new "default" directories. So after a person make this call, then they have to go and make modifications to these directories on the local disk to set up the instance.

          If we are going to have a gogo/karaf command to do this for us, what we really need is to have the var, etc, and repository directories generated new each time deploy:new-instance is called. And still then, we need a way to configure the new instance from gogo/karaf commands as well.

          Otherwise, we might as well abandon this procedure and use a different procedure that allows us to deploy an archive that contains an admin-user-modified var/etc/repository bundle.

          Or I guess, deploy:new-instance could allow (optionally) a new-instance-archive to be passed in as an argument.

          Show
          Russell E Glaue added a comment - GERONIMO-5988 duplicates this issue. A new instance requires var, etc, and repository else it won't start up. The documented method is a straight copy of these directories to the instance directory. A problem with this method is if the directories being copied have already been modified from a separate run-time execution. deploy:new-instance would only copy the directories instead of generating new "default" directories. So after a person make this call, then they have to go and make modifications to these directories on the local disk to set up the instance. If we are going to have a gogo/karaf command to do this for us, what we really need is to have the var, etc, and repository directories generated new each time deploy:new-instance is called. And still then, we need a way to configure the new instance from gogo/karaf commands as well. Otherwise, we might as well abandon this procedure and use a different procedure that allows us to deploy an archive that contains an admin-user-modified var/etc/repository bundle. Or I guess, deploy:new-instance could allow (optionally) a new-instance-archive to be passed in as an argument.
          Russell E Glaue made changes -
          Link This issue is duplicated by GERONIMO-6287 [ GERONIMO-6287 ]
          Hide
          Russell E Glaue added a comment -

          Regarding patch GERONIMO-5164/new-instance+30.patch

          I would remove the comment in the patch that reads:

          +        //?? repository folder needed by karaf, but don't know why ?
          

          If a comment is desired, I recommend this:

          +        //the repository folder is needed for local deployments, defined in etc/org.ops4j.pax.url.mvn.cfg
          +        //we want to deploy artifacts specific to the instance to this local repository, not the shared bootstrap repository
          

          See also: GERONIMO-6287#comment-13240477

          Show
          Russell E Glaue added a comment - Regarding patch GERONIMO-5164 /new-instance+30.patch I would remove the comment in the patch that reads: + //?? repository folder needed by karaf, but don't know why ? If a comment is desired, I recommend this: + //the repository folder is needed for local deployments, defined in etc/org.ops4j.pax.url.mvn.cfg + //we want to deploy artifacts specific to the instance to this local repository, not the shared bootstrap repository See also: GERONIMO-6287#comment-13240477
          Hide
          Shawn Jiang added a comment -

          Agreed, I meant to use that patch as a base and we definitely need to revise it.

          Show
          Shawn Jiang added a comment - Agreed, I meant to use that patch as a base and we definitely need to revise it.
          Hide
          Shawn Jiang added a comment -

          Use GERONIMO-6287 to track this issue.

          Show
          Shawn Jiang added a comment - Use GERONIMO-6287 to track this issue.
          Shawn Jiang made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Duplicate [ 3 ]

            People

            • Assignee:
              Shawn Jiang
              Reporter:
              Vanessa Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development