Geronimo
  1. Geronimo
  2. GERONIMO-4753

Upgrade dwr to 3.0.M1 or figure out why it won't work

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: buildsystem, console
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      The last artifact in the svn repo is dwr. We need to upgrade to 3.0.M1 which is available through maven or figure out some other strategy, possibly trying to convince the dwr team to release 2.0.5 through maven.

      1. screenshot-1.jpg
        189 kB
        Rex Wang
      2. GERONIMO-4753-trunk.patch
        13 kB
        Rex Wang

        Activity

        David Jencks created issue -
        Hide
        David Jencks added a comment -

        I went ahead and upgraded in rev 795946 (along with several other build tweaks). I couldn't see any problems in the console, but I also don't know where to look.

        Show
        David Jencks added a comment - I went ahead and upgraded in rev 795946 (along with several other build tweaks). I couldn't see any problems in the console, but I also don't know where to look.
        Hide
        Rex Wang added a comment -

        this should be an issue caused by this upgrade. I will take a look into it.
        -Rex

        Show
        Rex Wang added a comment - this should be an issue caused by this upgrade. I will take a look into it. -Rex
        Rex Wang made changes -
        Field Original Value New Value
        Attachment screenshot-1.jpg [ 12415105 ]
        Rex Wang made changes -
        Assignee Rex Wang [ rwonly ]
        Hide
        Rex Wang added a comment -

        The patch help migrate the code from dwr2.x to 3.x based.
        -Rex

        Show
        Rex Wang added a comment - The patch help migrate the code from dwr2.x to 3.x based. -Rex
        Rex Wang made changes -
        Attachment GERONIMO-4753-trunk.patch [ 12415438 ]
        Hide
        Rex Wang added a comment - - edited

        And DWR just shipped 3.0.rc1, holp the final can catch up our 2.2 release..
        -Rex

        Show
        Rex Wang added a comment - - edited And DWR just shipped 3.0.rc1, holp the final can catch up our 2.2 release.. -Rex
        Rex Wang made changes -
        Attachment example.json [ 12415623 ]
        Rex Wang made changes -
        Attachment example.json [ 12415623 ]
        Hide
        David Jencks added a comment -

        Committed patch in rev 803728.

        I'll try a build with 3.0rc1 and commit if I don't see anything wrong.

        Rex, are there any more code updates needed?

        Also, I see

        2009-08-12 15:23:38,328 WARN [DTDEntityResolver] Deprecated public id in dwr.xml. Use: <!DOCTYPE dwr PUBLIC "-//GetAhead Limited//DTD Direct Web Remoting 3.0//EN" "http://getahead.org/dwr//dwr30.dtd">
        

        when I look at a debugviews page in the console but I can't find any xml files that it might be referring to.

        Show
        David Jencks added a comment - Committed patch in rev 803728. I'll try a build with 3.0rc1 and commit if I don't see anything wrong. Rex, are there any more code updates needed? Also, I see 2009-08-12 15:23:38,328 WARN [DTDEntityResolver] Deprecated public id in dwr.xml. Use: <!DOCTYPE dwr PUBLIC "- //GetAhead Limited//DTD Direct Web Remoting 3.0//EN" "http://getahead.org/dwr//dwr30.dtd" > when I look at a debugviews page in the console but I can't find any xml files that it might be referring to.
        Hide
        David Jencks added a comment -

        AFAICT 3.0.rc1 is not yet released. Unless someone shows that its on a public repo I think we'll have to stick with 3.0M1

        Show
        David Jencks added a comment - AFAICT 3.0.rc1 is not yet released. Unless someone shows that its on a public repo I think we'll have to stick with 3.0M1
        Hide
        Rex Wang added a comment -

        I tried rc1 downloaded from http://directwebremoting.org/dwr/download.html directly.. Seems nobody in maven has taken the response to move it to a publice repo so far.
        In general, How much time do they need to make a stuff in place?

        -Rex

        Show
        Rex Wang added a comment - I tried rc1 downloaded from http://directwebremoting.org/dwr/download.html directly.. Seems nobody in maven has taken the response to move it to a publice repo so far. In general, How much time do they need to make a stuff in place? -Rex
        Hide
        David Jencks added a comment -

        Ideally the dojo foundation would set up a repo that is automatically synched with maven central or arrange with sonatype to use their 3rd party OSS repo that is already auto-synched. Either way IIUC someone from dojo/dwr needs to start the process. I guess we could provide nudging and advice.

        Show
        David Jencks added a comment - Ideally the dojo foundation would set up a repo that is automatically synched with maven central or arrange with sonatype to use their 3rd party OSS repo that is already auto-synched. Either way IIUC someone from dojo/dwr needs to start the process. I guess we could provide nudging and advice.
        Hide
        Rex Wang added a comment -

        OK.. I will go to dwr mailing list to ask for that.

        and, currently I think there is not any new update codes against this jira, for the warning message, I prefer not to take a look into it immediately, because I am working on the improvement Geronimo-4790 Migrate debug-views code to base on the up-to-date dojo, which will re-write the portlets.

        -Rex

        Show
        Rex Wang added a comment - OK.. I will go to dwr mailing list to ask for that. and, currently I think there is not any new update codes against this jira, for the warning message, I prefer not to take a look into it immediately, because I am working on the improvement Geronimo-4790 Migrate debug-views code to base on the up-to-date dojo, which will re-write the portlets. -Rex
        Hide
        David Jencks added a comment -

        I think this work got completed?

        Show
        David Jencks added a comment - I think this work got completed?
        David Jencks made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Rex Wang added a comment -

        Sure. One little bit things, I still wait DWR guys pulish their DWR 3.0.rc1 to publish repo, and that will resovle the issue you found above: 2009-08-12 15:23:38,328 WARN [DTDEntityResolver] Deprecated public id in dwr.xml. Use: <!DOCTYPE dwr PUBLIC "-//GetAhead Limited//DTD Direct Web Remoting 3.0//EN" "http://getahead.org/dwr//dwr30.dtd">.

        DWR guys ever told they planed to publish the artifact by this month, but I still not found any update wrt this in their mailing list.

        -Rex

        Show
        Rex Wang added a comment - Sure. One little bit things, I still wait DWR guys pulish their DWR 3.0.rc1 to publish repo, and that will resovle the issue you found above: 2009-08-12 15:23:38,328 WARN [DTDEntityResolver] Deprecated public id in dwr.xml. Use: <!DOCTYPE dwr PUBLIC "-//GetAhead Limited//DTD Direct Web Remoting 3.0//EN" "http://getahead.org/dwr//dwr30.dtd">. DWR guys ever told they planed to publish the artifact by this month, but I still not found any update wrt this in their mailing list. -Rex
        Hide
        Kevan Miller added a comment -

        I added the following to server-log4j.properties to suppress the warning message, until the DWR problem is fixed:

        1. Avoid DWR WARN messages during startup and admin console Debug Views
        2. Can be removed once problem is fixed in DWR
          log4j.logger.org.directwebremoting.impl.DTDEntityResolver=ERROR
        Show
        Kevan Miller added a comment - I added the following to server-log4j.properties to suppress the warning message, until the DWR problem is fixed: Avoid DWR WARN messages during startup and admin console Debug Views Can be removed once problem is fixed in DWR log4j.logger.org.directwebremoting.impl.DTDEntityResolver=ERROR

          People

          • Assignee:
            Rex Wang
            Reporter:
            David Jencks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development