Geronimo
  1. Geronimo
  2. GERONIMO-4729

Duplicate clusterName value sets in config-subsitious.properties

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.1.5, 2.2
    • Fix Version/s: 2.1.5, 2.2
    • Component/s: Clustering
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      Any

      Description

      Look into config-subsitions.properties file, there are 2 places to set clustername as following:

      ClusterName=DEFAULT_CLUSTER
      ...
      clusterName=CLUSTER_NAME
      ...
      

      which will confuse users when they are going to set up a clustering/farming environment.

      Can we improve this?

      Jeff

      1. Geronimo-4729-trunk.patch
        4 kB
        Rex Wang
      2. Geronimo-4729-b21.patch
        4 kB
        Rex Wang

        Issue Links

          Activity

          Hide
          Rex Wang added a comment -

          agree, I'd like improve this

          -Rex

          Show
          Rex Wang added a comment - agree, I'd like improve this -Rex
          Hide
          Rex Wang added a comment -

          patch for trunk.

          Show
          Rex Wang added a comment - patch for trunk.
          Hide
          Rex Wang added a comment -

          patch for branch 2.1

          Show
          Rex Wang added a comment - patch for branch 2.1
          Hide
          Rex Wang added a comment -

          the patches rename the
          clusterName -> FarmName
          ClusterName -> WADIClusterName
          clusterNodeName -> ClusterNodeName

          and the default value from
          FarmName: CLUSTER_NAME -> DEFAULT_FARM
          WADIClusterName: DEFAULT_CLUSTER -> DEFAULT_WADI_CLUSTER

          -Rex

          Show
          Rex Wang added a comment - the patches rename the clusterName -> FarmName ClusterName -> WADIClusterName clusterNodeName -> ClusterNodeName and the default value from FarmName: CLUSTER_NAME -> DEFAULT_FARM WADIClusterName: DEFAULT_CLUSTER -> DEFAULT_WADI_CLUSTER -Rex
          Hide
          Jarek Gawor added a comment -

          Committed the patch to trunk (revision 792581) and branches/2.1 (revision 792608). Thanks for the patch!

          Show
          Jarek Gawor added a comment - Committed the patch to trunk (revision 792581) and branches/2.1 (revision 792608). Thanks for the patch!
          Hide
          Rex Wang added a comment -

          fixed

          Show
          Rex Wang added a comment - fixed

            People

            • Assignee:
              Jarek Gawor
              Reporter:
              Chi Runhua
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development