Geronimo
  1. Geronimo
  2. GERONIMO-4723

Replace our dojo repackaging with the released dojo-war

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 3.0-M1
    • Component/s: web
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      dojo has a dojo-war that looks pretty similar to our repacked dojo war. I can't quite tell if it works. Maybe someone who understands what dojo does could try it?

        Activity

        Hide
        David Jencks added a comment -

        Patch that swaps the released dojo war for our repacked dojo war. It also has an attempt to remove the jasper dependency which might not work and is not essential.

        Show
        David Jencks added a comment - Patch that swaps the released dojo war for our repacked dojo war. It also has an attempt to remove the jasper dependency which might not work and is not essential.
        Hide
        Jay D. McHugh added a comment -

        (I accidentally put the wrong Jira number in the commit comment)

        Sending plugins/dojo/dojo-jetty/pom.xml
        Sending plugins/dojo/dojo-jetty/src/main/history/dependencies.xml
        Sending plugins/dojo/dojo-tomcat/pom.xml
        Sending plugins/dojo/dojo-tomcat/src/main/history/dependencies.xml
        Sending plugins/dojo/pom.xml
        Transmitting file data .....
        Committed revision 793687.

        Show
        Jay D. McHugh added a comment - (I accidentally put the wrong Jira number in the commit comment) Sending plugins/dojo/dojo-jetty/pom.xml Sending plugins/dojo/dojo-jetty/src/main/history/dependencies.xml Sending plugins/dojo/dojo-tomcat/pom.xml Sending plugins/dojo/dojo-tomcat/src/main/history/dependencies.xml Sending plugins/dojo/pom.xml Transmitting file data ..... Committed revision 793687.
        Hide
        David Jencks added a comment -

        So, apparently this works fine for current dojo. The legacy 0.4.3 dojo doesn't seem to be released to maven but is in an accessible svn repo.

        rev 794168 in externals/trunk builds a dojo 0.4.3 war directly from a svn checkout of the dojo source.

        Could someone see what happens if we build and use this instead of plugins/dojo-legacy/geronimo-dojo-legacy?

        Show
        David Jencks added a comment - So, apparently this works fine for current dojo. The legacy 0.4.3 dojo doesn't seem to be released to maven but is in an accessible svn repo. rev 794168 in externals/trunk builds a dojo 0.4.3 war directly from a svn checkout of the dojo source. Could someone see what happens if we build and use this instead of plugins/dojo-legacy/geronimo-dojo-legacy?
        Hide
        Rex Wang added a comment -

        Has been fixed, so closing it.

        Show
        Rex Wang added a comment - Has been fixed, so closing it.

          People

          • Assignee:
            Unassigned
            Reporter:
            David Jencks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development