[GERONIMO-4525] No effective exit code for all Windows commands

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.3
• Fix Version/s: 2.1.4, 2.2
• Component/s: commands
• Security Level: public (Regular issues)

Environment

MS Windows

• Patch Info: Patch Available
• Assignee: Jarek Gawor
• Reporter: Jun Jie Cai
• Created: 03/Feb/09 07:19
• Updated: 11/Feb/09 07:13
• Resolved: 10/Feb/09 22:04

Description

There are multiple problems in the current Windows batch commands (including geronimo.bat, startup.bat, etc.)

• It's not recommended to define an environment variable with the name ERRORLEVEL. See [1].
• Set a value to ERRORLEVEL has no effect to the exit code of the batch command (so the documented exit code "0" and "1" are not actually there).
• The value of the ERRORLEVEL variable will also get unset when the "@endlocal" command is called.

[1] http://blogs.msdn.com/oldnewthing/archive/2008/09/26/8965755.aspx