Geronimo
  1. Geronimo
  2. GERONIMO-4415

monitoring console code needs improvement

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: monitoring
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      The code quality in the monitoring console is not ideal. There are oddities such as static variables in stateless ejbs and a lot of code duplication for generating the graph javascript. In addition the monitoring console should be using jpa rather than direct db access for easier maintenance.

      Whether the agent should be using jpa is certainly debatable, I don't plan to change that right now.

        Activity

        Hide
        David Jencks added a comment -

        Some initial work in rev 718393. I also added a little test server for convenience, build with -Pit to include it.

        Show
        David Jencks added a comment - Some initial work in rev 718393. I also added a little test server for convenience, build with -Pit to include it.
        Hide
        David Jencks added a comment -

        Trygve Harderson noticed that the use of a SimpleCredentialStore for the subject used by the ejb timer so the timeout can access MEJB means that if you change the system/manager password you also have to update the credential store.

        The obvious way to fix this is to create a new realm solely for the use of this credential store that generates a subject with only the mejb-user principal.

        Show
        David Jencks added a comment - Trygve Harderson noticed that the use of a SimpleCredentialStore for the subject used by the ejb timer so the timeout can access MEJB means that if you change the system/manager password you also have to update the credential store. The obvious way to fix this is to create a new realm solely for the use of this credential store that generates a subject with only the mejb-user principal.
        Hide
        Donald Woods added a comment -

        We need to resolve this before we release 2.2, as we want users to change the default system pwd.

        Show
        Donald Woods added a comment - We need to resolve this before we release 2.2, as we want users to change the default system pwd.
        Hide
        David Jencks added a comment -

        Use new feature from GERONIMO-4445 to provide a "private" security realm for the default subject used to call the MEJB. Since we aren't using the system/manager identity for calling the MEJB we shouldn't run into any problems changing this user.

        Show
        David Jencks added a comment - Use new feature from GERONIMO-4445 to provide a "private" security realm for the default subject used to call the MEJB. Since we aren't using the system/manager identity for calling the MEJB we shouldn't run into any problems changing this user.
        Hide
        David Jencks added a comment -

        I don't anticipate any more code cleanup for 2.2, however desirable it might be.

        Show
        David Jencks added a comment - I don't anticipate any more code cleanup for 2.2, however desirable it might be.

          People

          • Assignee:
            David Jencks
            Reporter:
            David Jencks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development