Uploaded image for project: 'Geronimo'
  1. Geronimo
  2. GERONIMO-421

Better handling for null/empty users in default LoginModules

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0-M2
    • Fix Version/s: 1.0-M4
    • Component/s: security
    • Labels:
      None

      Description

      The PropertiesFileLoginModule throws an assertion error if no username is provided. I think this should just return false (or worst case, throw a regular LoginException) instead. I expect it to be unusual that the username would be null, but if so, it's just a plain failed login, right?

      The SQLLoginModule doesn't seem to check at all, and would throw a NullPointerException if the user was null. Whatever we decide on the other one, we should do it here too.

        Attachments

          Activity

            People

            • Assignee:
              ammulder Aaron Mulder
              Reporter:
              ammulder Aaron Mulder
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: