Geronimo
  1. Geronimo
  2. GERONIMO-4140

Update quartz plugin to geronimo 2.1+

    Details

    • Type: New Feature New Feature
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.1.2, 2.2
    • Fix Version/s: None
    • Component/s: Plugins
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      Aaron very kindly donated his quartz plugin, currently at sandbox/quartz-plugin. We should update it to a g. 2.1 plugin and release it.

        Activity

        Hide
        David Jencks added a comment -

        Hi Ivan,

        (a) My current preference is to generate the jaxb classes once and check them into svn somewhere under src/main/java. If we do this then the classes should be changed to include the standard apache header. Doing this lets you customize the code and for instance use sxc more easily. It's also possible to generate the code during the build into target/generated-sources/ using one of the maven xjc plugins. I think this method is used in framework/modules/geronimo-system.

        (b) I don't know how the current plugin works. If we have ejb injection into the quartz task that seems to me to be a very good feature. Could you explain in more detail what you are thinking?

        (c) Better console support would be wonderful! Getting the plugin to work at all would be great!

        You might get more response by discussing these ideas on the dev list.

        Show
        David Jencks added a comment - Hi Ivan, (a) My current preference is to generate the jaxb classes once and check them into svn somewhere under src/main/java. If we do this then the classes should be changed to include the standard apache header. Doing this lets you customize the code and for instance use sxc more easily. It's also possible to generate the code during the build into target/generated-sources/ using one of the maven xjc plugins. I think this method is used in framework/modules/geronimo-system. (b) I don't know how the current plugin works. If we have ejb injection into the quartz task that seems to me to be a very good feature. Could you explain in more detail what you are thinking? (c) Better console support would be wonderful! Getting the plugin to work at all would be great! You might get more response by discussing these ideas on the dev list.
        Hide
        Ivan added a comment -

        I am looking at this JIRA now, and part of the migration work has been done, so far, I have some questions, thanks for any comment.
        a. I use the JAXB to support multi-triggers with one quartz job, my question is that I use the xjc in the JDK's bin directory to generate some binding classes, do we need to keep those generated message in the generated java file ? do we need to add Apache license to the head of the file ? I found some source code in geronimo does it, and some not.
        b. The old quartz version uses a DeploymentWatcher to monitor the deployment process, it will search the geronimo-quartz.xml file in the deployment process, so that it will inject those ejb reference in the runtime. I wonder whether we really need this feature ? And if does, could we have a better solution to implement it, I just think importing a new schema file for this single plugin is not a good way. I am a newbie to Geronimo, could anyone shed light on it ?
        c. Currently, the quartz portlet is very simple, it only list all the running job, I suggest that we open a new JIRA to enforce it, for example, we could add new job dynamically, attach a new trigger ....
        Thanks !

        Show
        Ivan added a comment - I am looking at this JIRA now, and part of the migration work has been done, so far, I have some questions, thanks for any comment. a. I use the JAXB to support multi-triggers with one quartz job, my question is that I use the xjc in the JDK's bin directory to generate some binding classes, do we need to keep those generated message in the generated java file ? do we need to add Apache license to the head of the file ? I found some source code in geronimo does it, and some not. b. The old quartz version uses a DeploymentWatcher to monitor the deployment process, it will search the geronimo-quartz.xml file in the deployment process, so that it will inject those ejb reference in the runtime. I wonder whether we really need this feature ? And if does, could we have a better solution to implement it, I just think importing a new schema file for this single plugin is not a good way. I am a newbie to Geronimo, could anyone shed light on it ? c. Currently, the quartz portlet is very simple, it only list all the running job, I suggest that we open a new JIRA to enforce it, for example, we could add new job dynamically, attach a new trigger .... Thanks !

          People

          • Assignee:
            Unassigned
            Reporter:
            David Jencks
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development