Geronimo
  1. Geronimo
  2. GERONIMO-3654

Moving o.a.g.s.jaas.NamedUPCredentailLoginModule to o.a.g.s.realm.providers

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1
    • Fix Version/s: 2.0.3, 2.1
    • Component/s: security
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      David Jencks suggested that we move org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule to org.apache.geronimo.security.realm.providers package. I intend to do the following.
      1. svn copy org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule to org.apache.geronimo.security.realm.providers.NamedUPCredentailLoginModule
      2. Make org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule extend org.apache.geronimo.security.realm.providers.NamedUPCredentailLoginModule.
      3. Mark org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule as deprecated.
      4. Change all references from org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule to org.apache.geronimo.security.realm.providers.NamedUPCredentailLoginModule

      Does anyone see this coming in the way of compatibility? I do not intend to change the option name "org.apache.geronimo.jaas.NamedUPCredentialLoginModule.Name" as this will surely break compatibility. Whether or not the move breaks compatibility, should we consider this move only in trunk and not in branches\2.0?

        Activity

        Joe Bohn made changes -
        Fix Version/s 2.0.3 [ 12313315 ]
        Fix Version/s 2.0.x [ 12312601 ]
        Affects Version/s 2.0.2 [ 12312731 ]
        Affects Version/s 2.0.x [ 12312601 ]
        Vamsavardhana Reddy made changes -
        Field Original Value New Value
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Hide
        Vamsavardhana Reddy added a comment -

        Completed: At revision: 602089
        o Copied o.a.g.s.jaas.NamedUPCredentailLoginModule to o.a.g.s.realm.providers.NamedUsernamePasswordCredentialLoginModule
        o Marked NamedUPCredentialLoginModule as deprecated
        o Changed all references from o.a.g.s.jaas.NamedUPCredentialLoginModule to o.a.g.s.realm.providers.NamedUsernamePasswordCredentialLoginModule

        Show
        Vamsavardhana Reddy added a comment - Completed: At revision: 602089 o Copied o.a.g.s.jaas.NamedUPCredentailLoginModule to o.a.g.s.realm.providers.NamedUsernamePasswordCredentialLoginModule o Marked NamedUPCredentialLoginModule as deprecated o Changed all references from o.a.g.s.jaas.NamedUPCredentialLoginModule to o.a.g.s.realm.providers.NamedUsernamePasswordCredentialLoginModule
        Hide
        Vamsavardhana Reddy added a comment -

        On the second thought, I am planning to skip step 2 from the above. I will mark org.apache.geronimo.jaas.NamedUPCredentialLoginModule as deprecated only. We can remove the class from the codebase after the next release.

        Show
        Vamsavardhana Reddy added a comment - On the second thought, I am planning to skip step 2 from the above. I will mark org.apache.geronimo.jaas.NamedUPCredentialLoginModule as deprecated only. We can remove the class from the codebase after the next release.
        Vamsavardhana Reddy created issue -

          People

          • Assignee:
            Vamsavardhana Reddy
            Reporter:
            Vamsavardhana Reddy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development