Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1
    • Fix Version/s: 2.0.3, 2.1
    • Component/s: security
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      UPCredentialLoginModule seems to serve the same purpose as GeronimoPasswordCredentialLoginModule. Searching the codebase for references to UPCredentialLoginModule yields no results. Also GeronimoPasswordCredentialLoginModule is the one used by Security realms portlet. It may be a good idea to eliminate UPCredentialLoginModule and related classes.

        Activity

        Hide
        David Jencks added a comment -

        OK. It might be a good idea to move NamedUPCredentialLoginModule to o.a.g.s.realm.providers as long as we are breaking backward compatibility anyway.

        Show
        David Jencks added a comment - OK. It might be a good idea to move NamedUPCredentialLoginModule to o.a.g.s.realm.providers as long as we are breaking backward compatibility anyway.
        Hide
        Vamsavardhana Reddy added a comment -

        I am afraid this JIRA is not about NamedUPCredentialLoginModule, but about UPCredentialLoginModule which has the exact same function as GeronimoPasswordCredentialLoginModule. Is there any need to retain UPCredentialLoginModule?

        Show
        Vamsavardhana Reddy added a comment - I am afraid this JIRA is not about NamedUPCredentialLoginModule, but about UPCredentialLoginModule which has the exact same function as GeronimoPasswordCredentialLoginModule. Is there any need to retain UPCredentialLoginModule?
        Hide
        Vamsavardhana Reddy added a comment -

        For now, I have marked UPCredentialLoginModule as deprecated. We will remove the class from the codebase after the next release.

        Completed: At revision: 599796
        o Marked UPCredentialLoginModule as deprecated.
        o Replaced the only reference to UPCredentialLoginModule in ConfigurationEntryTest with GeronimoPasswordCredentialLoginModule.

        Show
        Vamsavardhana Reddy added a comment - For now, I have marked UPCredentialLoginModule as deprecated. We will remove the class from the codebase after the next release. Completed: At revision: 599796 o Marked UPCredentialLoginModule as deprecated. o Replaced the only reference to UPCredentialLoginModule in ConfigurationEntryTest with GeronimoPasswordCredentialLoginModule.

          People

          • Assignee:
            Vamsavardhana Reddy
            Reporter:
            Vamsavardhana Reddy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development