Geronimo
  1. Geronimo
  2. GERONIMO-3546

sharedlib config should not start rmi-naming when used with offline deployer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1
    • Fix Version/s: 2.0.3, 2.1
    • Component/s: dependencies, usability
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      G 2.0.2 tomcat on WinXP

    • Patch Info:
      Patch Available

      Description

      sharedlib config has a dependency on rmi-naming. If a configuration that depends on sharedlib is to be deployed using offline deployer (see GERONIMO-3544), the required changes will result in rmi-naming config getting started during deployment which will result in bind exception while using multiple server instances. See GERONIMO-3481. Since sharedlib only requires ServerInfo gbean which is part of j2ee-system config, it shouldn't harm making the sharedlib depend on j2ee-system instead of rmi-naming.

        Issue Links

          Activity

          Vamsavardhana Reddy created issue -
          Vamsavardhana Reddy made changes -
          Field Original Value New Value
          Link This issue blocks GERONIMO-3544 [ GERONIMO-3544 ]
          Vamsavardhana Reddy made changes -
          Link This issue relates to GERONIMO-3481 [ GERONIMO-3481 ]
          Hide
          Vamsavardhana Reddy added a comment -

          Completed: At revision: 587515

          Show
          Vamsavardhana Reddy added a comment - Completed: At revision: 587515
          Vamsavardhana Reddy made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Hide
          David Jencks added a comment -

          I ithink this will cause problems

          • I think people will expect spec classes to be available in shared/lib and will be surprised by NCDFE otherwise
          • to fix the offline deployer situation we may need to make the reference to serverInfo an optional single valued dependency so it can pick up the offline deployer's serverInfo

          I think making all the parents <import>classes</import> is worth a try as an alternate fix.

          Show
          David Jencks added a comment - I ithink this will cause problems I think people will expect spec classes to be available in shared/lib and will be surprised by NCDFE otherwise to fix the offline deployer situation we may need to make the reference to serverInfo an optional single valued dependency so it can pick up the offline deployer's serverInfo I think making all the parents <import>classes</import> is worth a try as an alternate fix.
          Vamsavardhana Reddy made changes -
          Status Closed [ 6 ] Reopened [ 4 ]
          Resolution Fixed [ 1 ]
          Hide
          Vamsavardhana Reddy added a comment -

          When I change the sharedlib's dependency on rmi-naming to <import>classes</import>, I am getting the following build error:

          [INFO] Packaging module configuration: C:\G\server\tags\2.0.2\configs\sharedlib\target\plan\plan.xml
          [INFO] ------------------------------------------------------------------------
          [ERROR] BUILD ERROR
          [INFO] ------------------------------------------------------------------------
          [INFO] Unable to resolve reference "ServerInfo"
          in gbean org.apache.geronimo.configs/sharedlib/2.0.2/car?ServiceModule=org.a
          pache.geronimo.configs/sharedlib/2.0.2/car,j2eeType=GBean,name=SharedLib
          to a gbean matching the pattern [?j2eeType=GBean,name=ServerInfo#org.apache.
          geronimo.system.serverinfo.ServerInfo]
          due to: No matches for referencePatterns: [?j2eeType=GBean,name=ServerInfo#o
          rg.apache.geronimo.system.serverinfo.ServerInfo]

          Show
          Vamsavardhana Reddy added a comment - When I change the sharedlib's dependency on rmi-naming to <import>classes</import>, I am getting the following build error: [INFO] Packaging module configuration: C:\G\server\tags\2.0.2\configs\sharedlib\target\plan\plan.xml [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] Unable to resolve reference "ServerInfo" in gbean org.apache.geronimo.configs/sharedlib/2.0.2/car?ServiceModule=org.a pache.geronimo.configs/sharedlib/2.0.2/car,j2eeType=GBean,name=SharedLib to a gbean matching the pattern [?j2eeType=GBean,name=ServerInfo#org.apache. geronimo.system.serverinfo.ServerInfo] due to: No matches for referencePatterns: [?j2eeType=GBean,name=ServerInfo#o rg.apache.geronimo.system.serverinfo.ServerInfo]
          Hide
          Vamsavardhana Reddy added a comment -

          David,

          how do I handle this part: "to fix the offline deployer situation we may need to make the reference to serverInfo an optional single valued dependency so it can pick up the offline deployer's serverInfo"

          Show
          Vamsavardhana Reddy added a comment - David, how do I handle this part: "to fix the offline deployer situation we may need to make the reference to serverInfo an optional single valued dependency so it can pick up the offline deployer's serverInfo"
          Vamsavardhana Reddy made changes -
          Summary sharedlib config should depend on j2ee-system instead of rmi-naming sharedlib config should not start rmi-naming when used with offline deployer
          Hide
          Vamsavardhana Reddy added a comment -

          Rev 587806: Replacing rmi-naming dependency with j2ee-system resulted in NCDEF's for spec classes. Reinstated the rmi-naming dependency with <import>classes</import>

          Show
          Vamsavardhana Reddy added a comment - Rev 587806: Replacing rmi-naming dependency with j2ee-system resulted in NCDEF's for spec classes. Reinstated the rmi-naming dependency with <import>classes</import>
          Hide
          Vamsavardhana Reddy added a comment -

          Completed: At revision: 588019

          o Thanks to David Jencks for suggesting a better solution than the one I had cooked originally.
          o Reverse rev 587515 and 587806
          o Change the dependency scope of rmi-naming to runtime i.e. <import>classes</import>
          o Make SharedLib use SingleElementCollection for ServerInfo

          Show
          Vamsavardhana Reddy added a comment - Completed: At revision: 588019 o Thanks to David Jencks for suggesting a better solution than the one I had cooked originally. o Reverse rev 587515 and 587806 o Change the dependency scope of rmi-naming to runtime i.e. <import>classes</import> o Make SharedLib use SingleElementCollection for ServerInfo
          Vamsavardhana Reddy made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Hide
          Aman Nanner added a comment -

          Ok, I'd like to test this out, but I'm suddenly getting this build error:

               [exec] Downloading: file://D:\g20\g\repository//castor/castor/0.9.9.0-pre/castor-0.9.9.0-pre.pom
               [exec] [WARNING] Unable to get resource 'castor:castor:pom:0.9.9.0-pre' from repository module-local (file://D:\g20
          \g\repository/)
               [exec] Downloading: http://download.java.net/maven/1//castor/poms/castor-0.9.9.0-pre.pom
               [exec] [WARNING] Unable to get resource 'castor:castor:pom:0.9.9.0-pre' from repository java.net (http://download.j
          ava.net/maven/1/)
               [exec] Downloading: http://people.apache.org/repo/m2-incubating-repository//castor/castor/0.9.9.0-pre/castor-0.9.9.
          0-pre.pom
               [exec] [WARNING] Unable to get resource 'castor:castor:pom:0.9.9.0-pre' from repository apache-incubator (http://pe
          ople.apache.org/repo/m2-incubating-repository/)
               [exec] Downloading: http://repo1.maven.org/maven2/castor/castor/0.9.9.0-pre/castor-0.9.9.0-pre.pom
               [exec] [WARNING] Unable to get resource 'castor:castor:pom:0.9.9.0-pre' from repository central (http://repo1.maven
          .org/maven2)
               [exec] Downloading: file://D:\g20\g\repository//castor/castor/0.9.9.0-pre/castor-0.9.9.0-pre.jar
               [exec] [WARNING] Unable to get resource 'castor:castor:jar:0.9.9.0-pre' from repository module-local (file://D:\g20
          \g\repository/)
               [exec] Downloading: http://download.java.net/maven/1//castor/jars/castor-0.9.9.0-pre.jar
               [exec] [WARNING] Unable to get resource 'castor:castor:jar:0.9.9.0-pre' from repository java.net (http://download.j
          ava.net/maven/1/)
               [exec] Downloading: http://people.apache.org/repo/m2-incubating-repository//castor/castor/0.9.9.0-pre/castor-0.9.9.
          0-pre.jar
               [exec] [WARNING] Unable to get resource 'castor:castor:jar:0.9.9.0-pre' from repository apache-incubator (http://pe
          ople.apache.org/repo/m2-incubating-repository/)
               [exec] Downloading: http://repo1.maven.org/maven2/castor/castor/0.9.9.0-pre/castor-0.9.9.0-pre.jar
               [exec] [WARNING] Unable to get resource 'castor:castor:jar:0.9.9.0-pre' from repository central (http://repo1.maven
          .org/maven2)
               [exec] [INFO] ------------------------------------------------------------------------
               [exec] [ERROR] BUILD ERROR
               [exec] [INFO] ------------------------------------------------------------------------
               [exec] [INFO] Failed to resolve artifact.
          
               [exec] Missing:
               [exec] ----------
               [exec] 1) castor:castor:jar:0.9.9.0-pre
          
               [exec]   Try downloading the file manually from the project website.
          
               [exec]   Then, install it using the command:
               [exec]       mvn install:install-file -DgroupId=castor -DartifactId=castor \
               [exec]           -Dversion=0.9.9.0-pre -Dpackaging=jar -Dfile=/path/to/file
          
               [exec]   Path to dependency:
               [exec]     1) org.apache.geronimo:repository:jar:2.0.2
               [exec]     2) org.codehaus.mojo.jspc:jspc-maven-plugin:jar:2.0-alpha-1-20070806
               [exec]     3) org.codehaus.mojo.groovy:groovy-mojo-support:jar:1.0-alpha-3
               [exec]     4) org.codehaus.mojo.groovy:groovy-mojo-common:jar:1.0-alpha-3
               [exec]     5) groovy:groovy-all:jar:1.0
               [exec]     6) openejb:openejb-loader:jar:1.0
               [exec]     7) openejb:openejb-core:jar:1.0
               [exec]     8) castor:castor:jar:0.9.9.0-pre
          
               [exec] ----------
               [exec] 1 required artifact is missing.
          
               [exec] for artifact:
               [exec]   org.apache.geronimo:repository:jar:2.0.2
          
               [exec] from the specified remote repositories:
               [exec]   central (http://repo1.maven.org/maven2),
               [exec]   java.net (http://download.java.net/maven/1/),
               [exec]   apache.snapshots (http://people.apache.org/repo/m2-snapshot-repository),
               [exec]   apache-snapshots (http://people.apache.org/repo/m2-snapshot-repository),
               [exec]   codehaus-snapshots (http://snapshots.repository.codehaus.org),
               [exec]   apache-incubator (http://people.apache.org/repo/m2-incubating-repository/),
               [exec]   module-local (file://D:\g20\g\repository/)
          

          Is this because the repository servers are down? Or would this indicate some kind of build corruption?

          Show
          Aman Nanner added a comment - Ok, I'd like to test this out, but I'm suddenly getting this build error: [exec] Downloading: file: //D:\g20\g\repository//castor/castor/0.9.9.0-pre/castor-0.9.9.0-pre.pom [exec] [WARNING] Unable to get resource 'castor:castor:pom:0.9.9.0-pre' from repository module-local (file: //D:\g20 \g\repository/) [exec] Downloading: http: //download.java.net/maven/1//castor/poms/castor-0.9.9.0-pre.pom [exec] [WARNING] Unable to get resource 'castor:castor:pom:0.9.9.0-pre' from repository java.net (http: //download.j ava.net/maven/1/) [exec] Downloading: http: //people.apache.org/repo/m2-incubating-repository//castor/castor/0.9.9.0-pre/castor-0.9.9. 0-pre.pom [exec] [WARNING] Unable to get resource 'castor:castor:pom:0.9.9.0-pre' from repository apache-incubator (http: //pe ople.apache.org/repo/m2-incubating-repository/) [exec] Downloading: http: //repo1.maven.org/maven2/castor/castor/0.9.9.0-pre/castor-0.9.9.0-pre.pom [exec] [WARNING] Unable to get resource 'castor:castor:pom:0.9.9.0-pre' from repository central (http: //repo1.maven .org/maven2) [exec] Downloading: file: //D:\g20\g\repository//castor/castor/0.9.9.0-pre/castor-0.9.9.0-pre.jar [exec] [WARNING] Unable to get resource 'castor:castor:jar:0.9.9.0-pre' from repository module-local (file: //D:\g20 \g\repository/) [exec] Downloading: http: //download.java.net/maven/1//castor/jars/castor-0.9.9.0-pre.jar [exec] [WARNING] Unable to get resource 'castor:castor:jar:0.9.9.0-pre' from repository java.net (http: //download.j ava.net/maven/1/) [exec] Downloading: http: //people.apache.org/repo/m2-incubating-repository//castor/castor/0.9.9.0-pre/castor-0.9.9. 0-pre.jar [exec] [WARNING] Unable to get resource 'castor:castor:jar:0.9.9.0-pre' from repository apache-incubator (http: //pe ople.apache.org/repo/m2-incubating-repository/) [exec] Downloading: http: //repo1.maven.org/maven2/castor/castor/0.9.9.0-pre/castor-0.9.9.0-pre.jar [exec] [WARNING] Unable to get resource 'castor:castor:jar:0.9.9.0-pre' from repository central (http: //repo1.maven .org/maven2) [exec] [INFO] ------------------------------------------------------------------------ [exec] [ERROR] BUILD ERROR [exec] [INFO] ------------------------------------------------------------------------ [exec] [INFO] Failed to resolve artifact. [exec] Missing: [exec] ---------- [exec] 1) castor:castor:jar:0.9.9.0-pre [exec] Try downloading the file manually from the project website. [exec] Then, install it using the command: [exec] mvn install:install-file -DgroupId=castor -DartifactId=castor \ [exec] -Dversion=0.9.9.0-pre -Dpackaging=jar -Dfile=/path/to/file [exec] Path to dependency: [exec] 1) org.apache.geronimo:repository:jar:2.0.2 [exec] 2) org.codehaus.mojo.jspc:jspc-maven-plugin:jar:2.0-alpha-1-20070806 [exec] 3) org.codehaus.mojo.groovy:groovy-mojo-support:jar:1.0-alpha-3 [exec] 4) org.codehaus.mojo.groovy:groovy-mojo-common:jar:1.0-alpha-3 [exec] 5) groovy:groovy-all:jar:1.0 [exec] 6) openejb:openejb-loader:jar:1.0 [exec] 7) openejb:openejb-core:jar:1.0 [exec] 8) castor:castor:jar:0.9.9.0-pre [exec] ---------- [exec] 1 required artifact is missing. [exec] for artifact: [exec] org.apache.geronimo:repository:jar:2.0.2 [exec] from the specified remote repositories: [exec] central (http: //repo1.maven.org/maven2), [exec] java.net (http: //download.java.net/maven/1/), [exec] apache.snapshots (http: //people.apache.org/repo/m2-snapshot-repository), [exec] apache-snapshots (http: //people.apache.org/repo/m2-snapshot-repository), [exec] codehaus-snapshots (http: //snapshots.repository.codehaus.org), [exec] apache-incubator (http: //people.apache.org/repo/m2-incubating-repository/), [exec] module-local (file: //D:\g20\g\repository/) Is this because the repository servers are down? Or would this indicate some kind of build corruption?
          Hide
          Vamsavardhana Reddy added a comment -

          In my local repository, I have castor-0.9.9.jar only. From where is it picking that version number "0.9.9.0-pre"?

          Show
          Vamsavardhana Reddy added a comment - In my local repository, I have castor-0.9.9.jar only. From where is it picking that version number "0.9.9.0-pre"?
          Joe Bohn made changes -
          Fix Version/s 2.0.x [ 12312601 ]
          Affects Version/s 2.0.x [ 12312601 ]
          Affects Version/s 2.0.2 [ 12312731 ]
          Fix Version/s 2.0.3 [ 12313315 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Closed Closed
          19m 39s 1 Vamsavardhana Reddy 23/Oct/07 15:21
          Closed Closed Reopened Reopened
          3h 26m 1 Vamsavardhana Reddy 23/Oct/07 18:48
          Reopened Reopened Closed Closed
          1d 3h 12m 1 Vamsavardhana Reddy 24/Oct/07 22:00

            People

            • Assignee:
              Vamsavardhana Reddy
              Reporter:
              Vamsavardhana Reddy
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development