[GERONIMO-349] Connector impl assumes ResourceAdapter.getXAResources != null

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-M2
• Fix Version/s: 1.0-M3
• Component/s: connector
• Assignee: Aaron Mulder
• Reporter: Aaron Mulder
• Created: 03/Oct/04 01:09
• Updated: 27/Sep/06 00:45
• Resolved: 03/Oct/04 18:33

Description

Deploy a resource adapter that does not support XA and where the ResourceAdapter implemntation of getXAResources returns null. This is allowed by the spec:

http://java.sun.com/j2ee/1.4/docs/api/javax/resource/spi/ResourceAdapter.html#getXAResources(javax.resource.spi.ActivationSpec[])

During Geronimo startup, I get:

20:44:09,098 ERROR [CollectionProxy] Listener threw exception
java.lang.reflect.InvocationTargetException
at org.apache.geronimo.gbean.jmx.GBeanMBeanAttribute.getValue(GBeanMBeanAttribute.java:316)
at org.apache.geronimo.gbean.jmx.GBeanMBean.getAttribute(GBeanMBean.java:630)
at org.apache.geronimo.gbean.jmx.RawInvoker.getAttribute(RawInvoker.java:53)
...
Caused by: java.lang.NullPointerException
at org.apache.geronimo.connector.ActivationSpecWrapper.getRecoveryXAResources(ActivationSpecWrapper.java:159)
at org.apache.geronimo.connector.ActivationSpecWrapper$$FastClassByCGLIB$$aaa078c1.invoke(<generated>)
at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:87)
at org.apache.geronimo.gbean.jmx.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
at org.apache.geronimo.gbean.jmx.GBeanMBeanAttribute.getValue(GBeanMBeanAttribute.java:313)
... 52 more

It appears that the ActivationSpecWrapper is assuming that the method would return an empty array and it blows up if the method returns null.

Issue Links

• duplicates: GERONIMO-265 NPE while deploying resource adapter