Geronimo
  1. Geronimo
  2. GERONIMO-2918

Have the ActiveMQ broker configured from an external configuration file by default

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2
    • Component/s: ActiveMQ
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      Currently, the org.apache.activemq.gbean.BrokerServiceGBeanImpl GBean is configured in the activemq-broker config and is thus built into a serialized configuration during the build process. Looking at the plan.xml, there is a commented-out section that specifies an external configuration file to be used. Enabling this section allows for the broker to be configured by an external file.

      This configuration should be changed so that the activemq-broker configuration refers to an external file by default, rather than being internally configured in the plan. This external file can exist somewhere in the geronimo folder hieracy (e.g. var/config/activemq.xml). This external file should contain the same minimal configuration that is currently specified in the GBean descriptor in the plan.xml.

      The benefit of having an external file by default is that the activemq broker can be configured without having to rebuild Geronimo. This makes the ActiveMQ configuration much easier.

        Activity

        Aman Nanner created issue -
        Hide
        Aman Nanner added a comment -

        Here is a patch that addresses this issue (and also addresses Geronimo 2927). There some comments in the activemq-broker pom.xml that can be removed.

        Show
        Aman Nanner added a comment - Here is a patch that addresses this issue (and also addresses Geronimo 2927). There some comments in the activemq-broker pom.xml that can be removed.
        Aman Nanner made changes -
        Field Original Value New Value
        Attachment activemq-config.patch [ 12353018 ]
        Hide
        Jason Dillon added a comment -

        I think the only way this would fly is if we can get the console bits which add connectors/etc to update the configuration file, so that one can still use the console to add muck and it will retain them over a restart.

        Perhaps, also, the console might need a simple text-based editor thingy to edit the activemq.xml

        Additionally, we may want to consider including the activemq-web-console...

        Show
        Jason Dillon added a comment - I think the only way this would fly is if we can get the console bits which add connectors/etc to update the configuration file, so that one can still use the console to add muck and it will retain them over a restart. Perhaps, also, the console might need a simple text-based editor thingy to edit the activemq.xml Additionally, we may want to consider including the activemq-web-console...
        Hide
        David Jencks added a comment -

        This is getting "fixed" in 2.2 as we upgrade to amq 5.2. I doubt the initial implementation will allow any editing of the amq config file: we might add some later.

        Show
        David Jencks added a comment - This is getting "fixed" in 2.2 as we upgrade to amq 5.2. I doubt the initial implementation will allow any editing of the amq config file: we might add some later.
        David Jencks made changes -
        Assignee David Jencks [ djencks ]
        Resolution Duplicate [ 3 ]
        Status Open [ 1 ] Closed [ 6 ]

          People

          • Assignee:
            David Jencks
            Reporter:
            Aman Nanner
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development