Geronimo
  1. Geronimo
  2. GERONIMO-2900

more readable output from list-modules when there's >1 target

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2, 2.0-M4
    • Component/s: usability
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
      Fedora Core release 4 (Stentz)

    • Patch Info:
      Patch Available

      Description

      The output from the cli deployer's list-modules command becomes hard to read when there is more than one target, since it prints the target for each module. The target name is long so you end up with something like:

      Found 20 modules
      + org.apache.geronimo.configs/clustering/1.2-SNAPSHOT/car on org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car,j2eeType=ConfigurationStore,name=Local
      + org.apache.geronimo.configs/connector-deployer/1.2-SNAPSHOT/car on org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car,j2eeType=ConfigurationStore,name=Local
      + org.apache.geronimo.configs/geronimo-gbean-deployer/1.2-SNAPSHOT/car on org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car,j2eeType=ConfigurationStore,name=Local
      + org.apache.geronimo.configs/hot-deployer/1.2-SNAPSHOT/car on org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car,j2eeType=ConfigurationStore,name=Local
      + org.apache.geronimo.configs/j2ee-deployer/1.2-SNAPSHOT/car on org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car,j2eeType=ConfigurationStore,name=Local

      etc...

      This patch changes the output so that if there's more than one target the modules are printed out per target. This is much easier to read:

      Found 20 modules deployed to 2 targets

      Target org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car,j2eeType=ConfigurationStore,name=Local
      + org.apache.geronimo.configs/clustering/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/connector-deployer/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/geronimo-gbean-deployer/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/hot-deployer/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/j2ee-deployer/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/j2ee-security/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/j2ee-server/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/jetty/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/jetty-deployer/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/remote-deploy-jetty/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/rmi-naming/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/sharedlib/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/transaction/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/unavailable-client-deployer/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/unavailable-ejb-deployer/1.2-SNAPSHOT/car
      + org.apache.geronimo.configs/unavailable-webservices-deployer/1.2-SNAPSHOT/car
      org.apache.geronimo.configs/online-deployer/1.2-SNAPSHOT/car
      org.apache.geronimo.configs/shutdown/1.2-SNAPSHOT/car

      Target org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/j2ee-system/1.2-SNAPSHOT/car,j2eeType=ConfigurationStore,name=Customer
      hello/g6o_RA/1/rar

        Activity

        Hide
        David Jencks added a comment -

        rev 515006 in trunk.

        Show
        David Jencks added a comment - rev 515006 in trunk.
        Hide
        David Jencks added a comment -

        Applied to 1.2 in rev 514826

        Show
        David Jencks added a comment - Applied to 1.2 in rev 514826
        Hide
        toby cabot added a comment -

        Patch to CommandListModules.java.

        Show
        toby cabot added a comment - Patch to CommandListModules.java.

          People

          • Assignee:
            David Jencks
            Reporter:
            toby cabot
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development