Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.2, 2.0-M1
    • Fix Version/s: 1.2, 2.0-M2
    • Component/s: None
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      A whole bunch of Java files in trunk (at least) are missing the apache license header. A basic list of such files can be generated with:

      find . -name "*.java" -exec fgrep -L 'Apache Software' {} \;

      1. license.patch
        59 kB
        Jarek Gawor
      2. license.patch.trunk
        76 kB
        Jarek Gawor

        Activity

        Hide
        Kevan Miller added a comment -

        By the way, ARAT had a bug. 'java' directories were assumed to be a java binary and ignored. It's been fixed in ARAT, but the svn repo is down at the moment.

        Show
        Kevan Miller added a comment - By the way, ARAT had a bug. 'java' directories were assumed to be a java binary and ignored. It's been fixed in ARAT, but the svn repo is down at the moment.
        Kevan Miller made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Kevan Miller added a comment -

        Fixes applied. Thanks a bunch Jarek!

        Show
        Kevan Miller added a comment - Fixes applied. Thanks a bunch Jarek!
        Jarek Gawor made changes -
        Attachment license.patch.trunk [ 12346829 ]
        Hide
        Jarek Gawor added a comment -

        Added patch for trunk.

        Show
        Jarek Gawor added a comment - Added patch for trunk.
        Jarek Gawor made changes -
        Attachment license.patch [ 12346822 ]
        Hide
        Jarek Gawor added a comment -

        Adds license headers to files that were missing it. This patch is for 1.2 branch. I hope I used the right version of the license header - otherwise, I can regenerate.

        Show
        Jarek Gawor added a comment - Adds license headers to files that were missing it. This patch is for 1.2 branch. I hope I used the right version of the license header - otherwise, I can regenerate.
        Kevan Miller made changes -
        Assignee Kevan Miller [ kevan ]
        Kevan Miller made changes -
        Field Original Value New Value
        Affects Version/s 2.0-M1 [ 12312216 ]
        Fix Version/s 1.2 [ 12310181 ]
        Affects Version/s 1.2 [ 12310181 ]
        Fix Version/s 2.0-M2 [ 12312217 ]
        Priority Minor [ 4 ] Blocker [ 1 ]
        Hide
        Kevan Miller added a comment -

        Bummer. ARAT should be flagging these. In fact it does, depending on what directory it runs against... Strange...

        There are files missing license headers and some files with old license headers. They all need to be fixed, prior to release...

        Jarek, if you're interested, a patch against branches/1.2 would be nice . Otherwise, I'll update later today...

        Show
        Kevan Miller added a comment - Bummer. ARAT should be flagging these. In fact it does, depending on what directory it runs against... Strange... There are files missing license headers and some files with old license headers. They all need to be fixed, prior to release... Jarek, if you're interested, a patch against branches/1.2 would be nice . Otherwise, I'll update later today...
        Jarek Gawor created issue -

          People

          • Assignee:
            Kevan Miller
            Reporter:
            Jarek Gawor
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development