[GERONIMO-2584] Hot deploy module/server restart, throws IllegalArgumentException if application deployed using hotdeployment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.1.2, 1.2, 2.0-M1
• Component/s: Hot Deploy Dir
• Security Level: public (Regular issues)

Environment

Windows XP, but should be valid for all platforms

• Patch Info: Patch Available
• Assignee: Vamsavardhana Reddy
• Reporter: Rakesh Midha
• Created: 20/Nov/06 10:16
• Updated: 02/May/13 02:29
• Resolved: 07/Dec/06 21:45

Description

This is a problem similar to one reported in https://issues.apache.org/jira/browse/GERONIMO-2402, the server restart or hot-deploy module restart fails with followng error if in a previous run you deployed an application using hot deployment.

The exception trace is :
00:54:43,008 ERROR [DirectoryMonitor] Unable to scan file C:\geronimo\geronimobu
ild\geronimo-tomcat-j2ee-1.2-SNAPSHOT\deploy\sampleHello during initialization
java.lang.IllegalArgumentException: Invalid id: sampleHello
at org.apache.geronimo.kernel.repository.Artifact.create(Artifact.java:4
9)
at org.apache.geronimo.deployment.hot.DirectoryHotDeployer.getDeployment
Time(DirectoryHotDeployer.java:216)
at org.apache.geronimo.deployment.hot.DirectoryMonitor.initialize(Direct
oryMonitor.java:233)
at org.apache.geronimo.deployment.hot.DirectoryMonitor.run(DirectoryMoni
tor.java:206)
at java.lang.Thread.run(Thread.java:534)
00:54:47,014 INFO [DirectoryHotDeployer] Deploying sampleHello
00:54:51,350 WARN [TomcatModuleBuilder] Web application . does not contain a WE
B-INF/geronimo-web.xml deployment plan. This may or may not be a problem, depen
ding on whether you have things like resource references that need to be resolve
d. You can also give the deployer a separate deployment plan file on the comman
d line.
00:54:51,841 ERROR [GBeanInstance] Problem in doFail of default/sampleHello/1163
964291070/war?J2EEApplication=null,j2eeType=WebModule,name=default/sampleHello/1
163964291070/war
java.lang.RuntimeException: java.lang.NullPointerException
at org.apache.geronimo.tomcat.TomcatContainer.removeContext(TomcatContai
ner.java:339)
at org.apache.geronimo.tomcat.TomcatContainer$$FastClassByCGLIB$$9370b07
3.invoke(<generated>)

... 31 more
00:54:51,841 ERROR [GBeanInstanceState] Error while starting; GBean is now in th
e FAILED state: abstractName="default/sampleHello/1163964291070/war?J2EEApplicat
ion=null,j2eeType=WebModule,name=default/sampleHello/1163964291070/war"
java.lang.IllegalArgumentException: addChild: Child name '/sampleHello' is not
unique
at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase
.java:749)

Caused by: org.apache.geronimo.gbean.InvalidConfigurationException: Configuratio
n default/sampleHello/1163964291070/war failed to start due to the following rea
sons:
The service J2EEApplication=null,j2eeType=WebModule,name=default/sampleHello/1
163964291070/war did not start because the doStart method threw an exception.
java.lang.IllegalArgumentException: addChild: Child name '/sampleHello' is not
unique
at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase
.java:749)

Steps to recreate:
1. Start server
2. Deploy sample application, by placing sampleApp folder in deploy directory
3. Application will be deployed and runs fine.
4. Restart server, or restart hot-deploy module
5. The above mentioned exception is thrown.

Issue Links

• blocks: GERONIMO-1431 Make deploy tool and hot deploy directory work better together
• depends upon: GERONIMO-2402 Redeployment fails after third iteration.
• duplicates: GERONIMO-2522 Hot deployer makes app hangs
• is duplicated by: GERONIMO-1982 server try to deploy the modules in hot deployment directory again during server startup