WinXP, G 1.1.1-rc1
GERONIMO-2382.patch: Validates name, host, port, minThreads, maxThreads, keystoreFile and keystorePassword fields. Checks for empty strings and non numerical values where applicable.
Comments on the patch:
The fields that are checked for being numeric should also be checked for being non-empty. Otherwise the portlet throws an exception when trying to save if they are emptyl.
Using the internal form names instead of the display names seems ok in these portlet since the internal name is just the concatenated form of the display name
Please note that checking numeric fields for empty is addressed in the dependency JIRA GERONIMO-2378.
OK thanks Vamsi – now I see the link to GERONIMO-2378 which addresses the empty numeric fields.
Thanks again Vamsi!