Geronimo
  1. Geronimo
  2. GERONIMO-2382

Webservers portlet - Form field validation using javascript

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.1
    • Fix Version/s: 1.1.2, 1.1.x, 1.2
    • Component/s: console
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Environment:

      WinXP, G 1.1.1-rc1

    • Patch Info:
      Patch Available

      Description

      Form field validation in DB Manager portlet using javascript.

      1. GERONIMO-2382.patch
        6 kB
        Vamsavardhana Reddy
      2. GERONIMO-2382-v2.patch
        6 kB
        Gianny Damour

        Issue Links

          Activity

          Hide
          Vamsavardhana Reddy added a comment -

          GERONIMO-2382.patch: Validates name, host, port, minThreads, maxThreads, keystoreFile and keystorePassword fields. Checks for empty strings and non numerical values where applicable.

          Show
          Vamsavardhana Reddy added a comment - GERONIMO-2382 .patch: Validates name, host, port, minThreads, maxThreads, keystoreFile and keystorePassword fields. Checks for empty strings and non numerical values where applicable.
          Hide
          Paul McMahan added a comment -

          Comments on the patch:
          The fields that are checked for being numeric should also be checked for being non-empty. Otherwise the portlet throws an exception when trying to save if they are emptyl.
          Using the internal form names instead of the display names seems ok in these portlet since the internal name is just the concatenated form of the display name

          Show
          Paul McMahan added a comment - Comments on the patch: The fields that are checked for being numeric should also be checked for being non-empty. Otherwise the portlet throws an exception when trying to save if they are emptyl. Using the internal form names instead of the display names seems ok in these portlet since the internal name is just the concatenated form of the display name
          Hide
          Vamsavardhana Reddy added a comment -

          Please note that checking numeric fields for empty is addressed in the dependency JIRA GERONIMO-2378.

          Show
          Vamsavardhana Reddy added a comment - Please note that checking numeric fields for empty is addressed in the dependency JIRA GERONIMO-2378 .
          Hide
          Gianny Damour added a comment -

          test

          Show
          Gianny Damour added a comment - test
          Hide
          Paul McMahan added a comment -

          OK thanks Vamsi – now I see the link to GERONIMO-2378 which addresses the empty numeric fields.

          Show
          Paul McMahan added a comment - OK thanks Vamsi – now I see the link to GERONIMO-2378 which addresses the empty numeric fields.
          Hide
          Gianny Damour added a comment -

          m2 layout

          Show
          Gianny Damour added a comment - m2 layout
          Hide
          Gianny Damour added a comment -

          Thanks again Vamsi!

          Show
          Gianny Damour added a comment - Thanks again Vamsi!

            People

            • Assignee:
              Gianny Damour
              Reporter:
              Vamsavardhana Reddy
            • Votes:
              3 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development